After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720215 - sdp: parse encryption key field
sdp: parse encryption key field
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.2.1
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-10 21:53 UTC by Aleix Conchillo Flaqué
Modified: 2013-12-17 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
parse encryption key field (1.07 KB, patch)
2013-12-10 21:55 UTC, Aleix Conchillo Flaqué
committed Details | Review

Description Aleix Conchillo Flaqué 2013-12-10 21:53:12 UTC
SDP library supports the SDP encryption key field. However, parsing is not implemented. RFC 4566 does not recommend the use of this field, but it hsould be parsed anyways.
Comment 1 Aleix Conchillo Flaqué 2013-12-10 21:55:50 UTC
Created attachment 263947 [details] [review]
parse encryption key field
Comment 2 Sebastian Dröge (slomo) 2013-12-14 11:32:06 UTC
Olivier, you might want to push this change now. Does this handle k=clear:XXX, k=base64:XXX and k=uri:XXX properly? If I understand the code correctly it skips until the : and only uses what comes afterwards as key, thus dropping any information about how to interpret the key.
Comment 3 Aleix Conchillo Flaqué 2013-12-14 16:36:47 UTC
(In reply to comment #2)
> Olivier, you might want to push this change now. Does this handle k=clear:XXX,
> k=base64:XXX and k=uri:XXX properly? If I understand the code correctly it
> skips until the : and only uses what comes afterwards as key, thus dropping any
> information about how to interpret the key.

  read_string_del (str, sizeof (str), ':', &p);

str will contain the first part before the delimiter and p will contain the second part. so, we have both the method and the key. read_string_del stores characters in str until the delimiter is found and return the pointer to the first character after the delimiter.
Comment 4 Sebastian Dröge (slomo) 2013-12-14 16:40:40 UTC
Ah right, I missed that str is also used later, not only p :) Nevermind then
Comment 5 Olivier Crête 2013-12-17 21:33:40 UTC
Committed

commit 7a7ae7d5f4e709e45596a11402e0356522262045
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Tue Dec 10 13:54:28 2013 -0800

    sdp: parse encryption key field
    
    * gst-libs/gst/sdp/gstsdpmessage.c: parse encryption key field (k).
    
      https://bugzilla.gnome.org/show_bug.cgi?id=720215