GNOME Bugzilla – Bug 719200
Use yelp-tools style directories
Last modified: 2016-07-01 23:32:35 UTC
---- Reported by shotwell-maint@gnome.bugs 2013-07-20 14:52:00 -0700 ---- Original Redmine bug id: 7255 Original URL: http://redmine.yorba.org/issues/7255 Searchable id: yorba-bug-7255 Original author: Jeremy Bicha Original description: See https://wiki.gnome.org/GnomeGoals/NewDocumentationInfrastructure I'm including a patch for this. ---- Additional Comments From shotwell-maint@gnome.bugs 2013-10-03 18:22:00 -0700 ---- ### History #### #1 Updated by Jeremy Bicha 4 months ago * **File** _0001-Closes-7255-Use-yelp-tools-style-help-install-direct.patch_ added #### #2 Updated by Jeremy Bicha 4 months ago * **File** _0001-Closes-7255-Use-yelp-tools-style-help-install-direct.patch_ added This fixes a minor issue in the previous patch. #### #3 Updated by Jeremy Bicha 4 months ago * **File** deleted (<strike>_0001-Closes-7255-Use-yelp-tools-style-help-install-direct.patch_</strike>) #### #4 Updated by Jeremy Bicha 4 months ago * **File** deleted (<strike>_0001-Closes-7255-Use-yelp-tools-style-help-install-direct.patch_</strike>) #### #5 Updated by Jeremy Bicha 4 months ago * **File** 0001-Closes-7255-Use-yelp-tools-style-help-install-direct.patch added #### #6 Updated by Jim Nelson 4 months ago * **Status** changed from _Open_ to _Review_ * **Target version** set to _0.15.0_ Thanks, we'll take a look at this soon. #### #7 Updated by Jim Nelson 4 months ago * **Status** changed from _Review_ to _Need Information_ Jeremy, one question / concern: In your patch, the way the Makefile uninstalls Shotwell's help is changed. It goes from this: rm -rf $(DESTDIR)$(PREFIX)/share/gnome/help/shotwell to this: rm -rf $(DESTDIR)$(PREFIX)/share/help Am I reading this right? It looks to me that uninstalling Shotwell will uninstall help for all applications. #### #8 Updated by Jim Nelson about 1 month ago * **Target version** deleted (<strike>_0.15.0_</strike>) --- Bug imported by chaz@yorba.org 2013-11-25 22:11 UTC --- This bug was previously known as _bug_ 7255 at http://redmine.yorba.org/show_bug.cgi?id=7255 Imported an attachment (id=262750) Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Jeremy, I had a question about this patch (see comment #7, above). Can you let me know?
The line for uninstalling help is definitely wrong: rm -rf $(DESTDIR)$(PREFIX)/share/help Should be, I suppose: rm -rf $(DESTDIR)$(PREFIX)/share/help/C/shotwell Note that if there are translations to install, you'll need to rm those directories separately, e.g.: rm -rf $(DESTDIR)$(PREFIX)/share/help/de/shotwell rm -rf $(DESTDIR)$(PREFIX)/share/help/es/shotwell Could always do something like this, I guess: rm -rf $(DESTDIR)$(PREFIX)/share/help/*/shotwell But wildcards like that with rm scare the bejezus out of me.
Created attachment 330380 [details] [review] Use yelp-tools style help install directories https://wiki.gnome.org/Initiatives/GnomeGoals/NewDocumentationInfrastructure
Created attachment 330758 [details] [review] Use yelp-tools style help install directories https://wiki.gnome.org/Initiatives/GnomeGoals/NewDocumentationInfrastructure
Updated my patch against current master.
(In reply to Jeremy Bicha from comment #5) > Updated my patch against current master. Whoops, forgot to apply the code part, sorry. Thanks for noticing.
Attachment 330758 [details] pushed as 40dbbea - Use yelp-tools style help install directories