GNOME Bugzilla – Bug 71286
should be able to go straight to "RESOLVED" from "NEEDINFO"
Last modified: 2005-02-27 00:14:57 UTC
It's a real pain to have to re-open a bug just to change it to "RESOLVED". In fact, I'd also like to be able to go to "ASSIGNED" directly from "NEEDINFO".
I tried to make a patch for this at one point, but it turns out to be rather more complex than I thought. The bugzilla developers upstream say this functionality will be available in the stock 2.18, but that seems quite some long time away. Perhaps I'll take another look at the code, and see how hard it really is.
Greg, any idea on this one?
Created attachment 37984 [details] [review] Patch v1 Patch adds NEEDINFO to the OpenStates. Without that, Bugzilla will not always do the right thing (example: NEEDINFO -> ASSIGNED won't work). After this NEEDINFO has the same options as a bug in UNCONFIRMED/NEW/REOPENED/ASSIGNED state. Patch also adds the closed option back to when the bug is in NEEDINFO, so the bug can still be closed like now. Note: Haven't fully tested all options/states, doing that now... seems to work though :)
Actually, I think I'd rather force a bug to go to one of the resolved states than straight to closed. I think Andrew said that going straight from needinfo to closed caused some sanity checks to fail; granted we do ignore those now, but I think it'd be nicer to always give a reason for closing a needinfo bug and thus just use the resolved state instead. Thoughts, opinions?
Created attachment 37987 [details] [review] Patch v2 Unconfirmed->needinfo didn't work. Also forgot to add an reopen for needinfo. Removed the needinfo->closed option. Passes the following checks: Mark unconfirmed bug needinfo Mark new bug needinfo Reopen needinfo everconfirmed=0 bug (state goes to unconfirmed) Reopen needinfo everconfirmed=1 bug (state goes to reopened) Reopen needinfo everconfirmed=1 bug + mark new (state goes to new) Accept needinfo bug (state goes to assigned) Marking needinfo duplicate (state goes to resolved duplicate) Marking needinfo fixed (state goes to resolved fixed) Following are possible errors: Reassign needinfo everconfirmed=1 bug (state goes to new) --> maybe not what we want? Also goes to new when reassigning to owner of selected component
Created attachment 37989 [details] [review] Patch v3 Reassigning now keeps the needinfo state. When a bug was never confirmed and the status is needinfo, I now hide the 'reassign and mark NEW' options. These make no sense after above change. This patch passes all my tests :)
Created attachment 37990 [details] [review] Additional patch to fix small issue Fixes small issue when bug had everconfirmed=1 and was in the needinfo state (the javascript selected the wrong 'knob'). Eg when you would fill in a duplicate number, actually the change resolution to fixed would be selected. Patch is to be applied after v3
Marking FIXED!! :-)
*** Bug 91210 has been marked as a duplicate of this bug. ***