After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712303 - qtdemux: playback regression after commit ae1150e85cf99d7482933aa6f7e4f012fe45a3ec
qtdemux: playback regression after commit ae1150e85cf99d7482933aa6f7e4f012fe4...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-14 14:42 UTC by Philippe Normand
Modified: 2013-11-15 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux:5 log (26.06 KB, application/x-gzip)
2013-11-14 14:42 UTC, Philippe Normand 		Details

Description Philippe Normand 2013-11-14 14:42:04 UTC 
Created attachment 259807 [details]
qtdemux:5 log

commit ae1150e85cf99d7482933aa6f7e4f012fe45a3ec
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Tue Oct 15 08:16:20 2013 +0200

    qtdemux: rename chunks_are_chunks to chunks_are_samples and flip the logic
    
    As the variable name suggests, sometimes chunks are chunks. Rename the variable
    to tell what they are when they are not chunks.

Broke playbin playback of:
http://trac.webkit.org/export/159284/trunk/LayoutTests/media/content/test.mp4
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2013-11-14 18:32:35 UTC 
This code is interesting:
0:00:00.144741694 17802 0x7f5ebc0cd6d0 DEBUG                qtdemux qtdemux.c:6169:qtdemux_stbl_init:<qtdemux0> sample_size = 6, is_sampled=1
0:00:00.144931357 17802 0x7f5ebc0cd6d0 DEBUG                qtdemux qtdemux.c:6169:qtdemux_stbl_init:<qtdemux0> sample_size = 0, is_sampled=1

Before the sample_size of the first stbl is reused in my case it is not.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2013-11-14 19:57:24 UTC 
commit 1a4e7338d902245a2a64b1c8e94ffe2766479185
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Thu Nov 14 20:54:32 2013 +0100

    qtmux: fix playback regression
    
    In ae1150e85cf99d7482933aa6f7e4f012fe45a3ec flipping a condition misaligned the
    else branch, where for there condition that was change there is none.
    Fixes #712303
Comment 3 Philippe Normand 2013-11-15 11:46:31 UTC 
Thanks!