After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712244 - GNOME Goal: Use g_timeout_add_seconds instead of g_timeout_add
GNOME Goal: Use g_timeout_add_seconds instead of g_timeout_add
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2013-11-13 20:04 UTC by Alexandre Franke
Modified: 2013-11-14 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Switch from g_timeout_add to g_timeout_add_seconds (5.03 KB, patch)
2013-11-14 18:02 UTC, Alexandre Franke 		committed Details | Review

Description Alexandre Franke 2013-11-13 20:04:03 UTC 
See https://wiki.gnome.org/GnomeGoals/UseTimeoutAddSeconds

I'm currently working on this and will submit a patch soon.
Comment 1 Alexandre Franke 2013-11-14 18:02:06 UTC 
Created attachment 259829 [details] [review]
Switch from g_timeout_add to g_timeout_add_seconds
Comment 2 Milan Crha 2013-11-14 19:04:58 UTC 
Review of attachment 259829 [details] [review]:

Nice, please make the one change and commit to master. Thanks.

::: camel/camel-operation.c
@@ +35,3 @@
 #define PROGRESS_DELAY		250  /* milliseconds */
 #define TRANSIENT_DELAY		250  /* milliseconds */
+#define POP_MESSAGE_DELAY	1    /* second */

Please call it 'seconds' (plural)
Comment 3 Alexandre Franke 2013-11-14 19:20:18 UTC 
Change done. Thanks for your quick review.

Attachment 259829 [details] pushed as b6befe4 - Switch from g_timeout_add to g_timeout_add_seconds