After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 71155 - some applets do not have generic menu items
some applets do not have generic menu items
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
1.5.x
Other Linux
: High major
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 71670 71672 72624 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-02-11 07:04 UTC by Gediminas Paulauskas
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.82 KB, patch)
2002-02-22 13:04 UTC, Shivram U 		none Details | Review

Description Gediminas Paulauskas 2002-02-11 07:04:38 UTC 
Some applets do not get "Remove From Panel" and "Move" menu items.

Every panel object should have them.

Strangely, if you kill the panel (applets do not die), and restart it,
those applets get move & remove menu items, and even at right position (at
the bottom of popup menu), differently from #71136

Applies only to out-of-proc applets, and only some of them: mixer,
screenshooter, mini-commander
Comment 1 Richard Hult 2002-02-11 09:01:28 UTC 
It seems to be some kind of race, or so. When panel_applet_setup_menu
is called from within the factory callback, the applet-frame's part of
the menu (move/remove) is not added. When calling setup_menu from an
idle, it works.
Comment 2 Richard Hult 2002-02-11 14:23:42 UTC 
After todays (20020211) changes to the panel, the mixer and multiload
applets work for me, but test-bonobo-applet still needs to do its
setup_menu in an idle to work.
Comment 3 Luis Villa 2002-02-14 05:01:43 UTC 
Cosmetic, but the kind of small, irritating cosmetic that 'real' users
expect us to get right, in my judgment. Ignore me if you think I'm
wrong :)
Comment 4 Mark McLoughlin 2002-02-20 11:00:58 UTC 
This is a quite serious bug becuase it makes it impossible to remove
applets from the panel
Comment 5 Shivram U 2002-02-22 13:03:24 UTC 
Create the popup BonoboUIComponent in the panel_applet_setup() 
function itself and store it in the PanelApplet private data.In 
panel_applet_setup_menu() and panel_applet_setup_menu_from_file() get 
the popup BonoboUIComponent from the PanelApplet private data. This 
solves the problem.

Attaching the patch.
Comment 6 Shivram U 2002-02-22 13:04:44 UTC 
Created attachment 6822 [details] [review]
patch
Comment 7 Luis Villa 2002-02-26 06:21:40 UTC 
Adding patch keyword. Shivaram: in the future, please cc: yourself to
bugs that you have attached patches to so that the maintainer can more
easily ask you questions about the patch.
Comment 8 Gediminas Paulauskas 2002-02-26 19:19:43 UTC 
*** Bug 72624 has been marked as a duplicate of this bug. ***
Comment 9 Gediminas Paulauskas 2002-02-26 19:21:35 UTC 
strange but... yes, with this patch all applets get generic menu
items, even mini-commander

ok to commit?
Comment 10 Luis Villa 2002-02-26 20:52:58 UTC 
Who was that question directed towards, Gedeminas?
Comment 11 Mark McLoughlin 2002-02-27 17:56:18 UTC 
This turned out to be a race condition/re-entancy bug in libbonoboui.

Fixed in CVS
Comment 12 Gediminas Paulauskas 2002-03-02 12:09:17 UTC 
*** Bug 71672 has been marked as a duplicate of this bug. ***
Comment 13 Gediminas Paulauskas 2002-03-02 12:29:41 UTC 
*** Bug 71670 has been marked as a duplicate of this bug. ***