After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711269 - systemclock: Add method to set the default system clock
systemclock: Add method to set the default system clock
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 711270
 
 
Reported: 2013-11-01 18:50 UTC by Torrie Fischer
Modified: 2013-11-11 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
systemclock: Add gst_system_clock_set_default (4.25 KB, patch)
2013-11-01 18:50 UTC, Torrie Fischer
committed Details | Review

Description Torrie Fischer 2013-11-01 18:50:31 UTC
Created attachment 258776 [details] [review]
systemclock: Add gst_system_clock_set_default

This patch adds a new method: gst_system_clock_set_default

It is used for setting the default system clock that is obtained through gst_system_clock_obtain() which is sometimes needed for unit testing, specifically for some RTP retransmission tests. This patch also includes a unit test for the new method.
Comment 1 Sebastian Dröge (slomo) 2013-11-01 19:09:28 UTC
In which use cases is the system clock used unconditionally instead of the pipeline clock? I mean, in which test can't you just force a specific clock on the pipeline to get the behaviour you want?
Comment 2 Torrie Fischer 2013-11-04 14:21:16 UTC
For bug #711270 which tests rtpsession, the rtpsession element has a call to gst_system_clock_obtain to handle RTP timeouts in a separate thread. It doesn't use the pipeline clock for that. A number of other RTP elements also have calls to gst_system_clock_obtain.
Comment 3 Wim Taymans 2013-11-11 11:36:09 UTC
commit 02b64ee03bfcdcd75c8d405f99dd4a2f0f7df164
Author: Wim Taymans <wim.taymans@gmail.com>
Date:   Mon Nov 11 12:25:14 2013 +0100

    systemclock: Add gst_system_clock_set_default
    
    Used for setting the default system clock that is obtained through
    gst_system_clock_obtain(), which is sometimes needed for unit
    testing.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=711269