After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709831 - filesrc: Improve unit test coverage by setting property in the "wrong" state...
filesrc: Improve unit test coverage by setting property in the "wrong" state...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other other
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-10 15:06 UTC by Sebastian Rasmussen
Modified: 2013-10-13 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for unit test. (2.69 KB, patch)
2013-10-10 15:06 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2013-10-10 15:06:09 UTC
Created attachment 256921 [details] [review]
Proposed patch for unit test.

A simple test added, and removal of an incorrect comment (because I prove that the code can be reached in the new unit test)
Comment 1 Olivier Crête 2013-10-13 16:22:05 UTC
Thank you, merged

commit 1479aba1cfa35e47aa2ab0a5d801ee148ec3fd71
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sun Sep 29 17:35:11 2013 +0200

    tests/filesrc: Set location in wrong state
    
    Also remove incorrect comment about code possibly not being reachable
    that is now exercised by the filesrc unit test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709831