After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709384 - videomixer: Check if the source pad needs reconfiguration and update the source caps in that case
videomixer: Check if the source pad needs reconfiguration and update the sour...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.2.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-03 19:46 UTC by Mathieu Duponchelle
Modified: 2013-10-04 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes the reported issue (862 bytes, patch)
2013-10-03 19:46 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2013-10-03 19:46:07 UTC 
Created attachment 256417 [details] [review]
fixes the reported issue

There was a case in my application where a pad would be removed, new caps would be calculated with respect to the peer pad, but as that pad was unlinked those caps ended up being any.

The source pad was relinked afterwards, but as videomixer didn't check its reconfigure flag it ended up sending the previously computed caps, which in my case were not accepted by the subsequent capsfilter.

The patch attached checks the reconfigure flag in _collected, and updates the source caps accordingly.
Comment 1 Sebastian Dröge (slomo) 2013-10-04 08:53:53 UTC 
commit 3d780c5c6d4d8987c0c73a13fab7dd20c6eb28d9
Author: Mathieu Duponchelle <mduponchelle1@gmail.com>
Date:   Thu Oct 3 21:36:34 2013 +0200

    videomixer: Check if the pad needs reconfiguration in collected
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709384