After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708757 - Please include an AppData file
Please include an AppData file
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: documentation
git master
Other Linux
: Normal enhancement
: GNOME3.12
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-25 14:58 UTC by Richard Hughes
Modified: 2013-10-30 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that works for me (2.77 KB, patch)
2013-09-25 14:58 UTC, Richard Hughes
none Details | Review
-- actually mark strings for translation (2.77 KB, patch)
2013-09-25 15:03 UTC, Richard Hughes
needs-work Details | Review

Description Richard Hughes 2013-09-25 14:58:14 UTC
Created attachment 255697 [details] [review]
patch that works for me

Eye of GNOME has no AppData file and looks bad in GNOME Software, the new software center for GNOME 3.10.

I've attached something that works for me. You'll have to check the contact details and prose for me. Thanks.
Comment 1 Richard Hughes 2013-09-25 15:03:17 UTC
Created attachment 255698 [details] [review]
-- actually mark strings for translation
Comment 2 Daniel Mustieles 2013-10-23 09:40:39 UTC
Review of attachment 255698 [details] [review]:

Must change the following line:
+@INTLTOOL_XML_NOMERGE_RULE@

to use @INTLTOOL_XML_RULE@

Anyway, this module should be branched to gnome-3-10 before applying the patch. Maintainers: could you please branch to gnome-3-10?

Thanks!
Comment 3 Felix Riemann 2013-10-25 13:48:50 UTC
(In reply to comment #2)
> Maintainers: could you please branch to gnome-3-10?

eog is already branched for gnome-3-10. ;)
Comment 4 Daniel Mustieles 2013-10-25 16:02:00 UTC
So, can the patch be commited?
Comment 5 Felix Riemann 2013-10-27 11:59:36 UTC
(In reply to comment #4)
> So, can the patch be commited?

Sure! I just thought docs would take care of it when everything's ready. :)
Anyway, I updated the Makefile to use intltool's GSettings support, so we can drop the NOMERGE rule (which is critical for distcheck).

commit 8f83ae4397bf7a477a154e5712b799fa43c60187
Author: Felix Riemann <>
Date:   Sun Oct 27 12:55:27 2013 +0100

    Use intltool's GSettings support
    
    Necessary to be able to build the AppData XML in the same folder.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708757

commit 44866d5177903e79d0fb1b9f2e313ae087bc3358
Author: Richard Hughes <>
Date:   Wed Sep 25 15:55:12 2013 +0100

    Add an AppData file
    
    See http://people.freedesktop.org/~hughsient/appdata/ for details.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708757
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Daniel Mustieles 2013-10-30 10:41:48 UTC
May thanks Félix for your help! :)