GNOME Bugzilla – Bug 708750
[patch] Please include an AppData file
Last modified: 2013-10-24 08:47:51 UTC
Created attachment 255687 [details] [review] patch that works for me I've attached a translated AppData file for Brasero. Thanks!
Brasero fails distcheck when I apply this patch with: make[2]: Entering directory `/home/mcatanzaro/brasero/brasero-3.8.0/_build/po' INTLTOOL_EXTRACT="/usr/bin/intltool-extract" XGETTEXT="/usr/bin/xgettext" srcdir=../../po /usr/bin/intltool-update --gettext-package brasero --pot can't open ../../po/../data/brasero.appdata.xml.in: No such file or directory at /usr/bin/intltool-extract line 212. /usr/bin/xgettext: error while opening "../data/brasero.appdata.xml.in.h" for reading: No such file or directory ERROR: xgettext failed to generate PO template file. Please consult error message above if there is any. Two thoughts: I think you need to distribute appdata_DATA instead of appdata_in_files. (That's surely what's causing distcheck to fail). Don't you need to use INTLTOOL_XML_RULE (rather than INTLTOOL_XML_NOMERGE_RULE) to merge the translations into brasero.appdata.xml?
Seems to be a bug in the patch: +data/brasero.appdata.xml.in should be +data/brasero.appdata.xml
brasero.appdata.xml.in is processed with intltool to generate brasero.appdata.xml. The problem is that brasero.appdata.xml is going into the tarball, whereas brasero.appdata.xml.in needs to instead.
Review of attachment 255687 [details] [review]: Fails distcheck, see above
Created attachment 256322 [details] [review] Rely on intltool 0.50 native gsettings support This lets us drop use of INTLTOOL_XML_NOMERGE_RULE in data/Makefile.am
Created attachment 256323 [details] [review] Add community-produced appdata file
Review of attachment 256322 [details] [review]: I'm far from an expert in autofoo but this looks good to me, please feel free to commit.
Review of attachment 256323 [details] [review]: This looks great, thanks. Please feel free to commit.
Hm, 3.10 never got released or branched, so this can't be committed right now as master is still under string freeze. (Is a late 3.10 release planned sometime soon?)
3.10.1 will be out in a few days. Branching now to gnome-3-10 would be nice to land this patch for the new release
(In reply to comment #10) > 3.10.1 will be out in a few days. Branching now to gnome-3-10 would be nice to > land this patch for the new release The issue is that translatable appdata -> new strings -> cannot go into 3.10.
I though that branching now to gnome-3-10 and commiting it into master would be included in the 3.10.1 release. Thanks for the info!
Could you please branch this module and apply the patch into master branch? Thanks!
gnome-3-10 branch created and patches applied to master - thanks. Apologies for the delay, hardware troubles.
Many thanks Joshua!