GNOME Bugzilla – Bug 708493
Zoom Options: Color effects sliders display incorrectly
Last modified: 2013-09-23 17:22:10 UTC
See the screen capture at: http://clown.idrc.ocad.ca/aegis/g-c-c/ColorEffectsSliders.png The sliders for the various colour effects don't fill out horizontally for a nightly build of gnome-control-center. In contrast, a similar slider in the crosshairs panel (for crosshairs length) does *not* show this problem: http://clown.idrc.ocad.ca/aegis/g-c-c/CrosshairsSlider.png Examining the zoom-options.ui file comparing the two sliders does not show significant differences. Viewing zoom-options.ui using glade-previewer within a jhbuild shell shows the problem. But, previewing the same file using the current F19 release, does not show the problem (gtk3-3.8.4-1fc19).
Created attachment 255452 [details] [review] universal access: Fix non-expanding sliders in zoom options The behaviour of the GtkBox expand child property changed in GTK+ 3.10, back to its traditional behaviour: It no longer propagates up. Propagation is now reserved for the GtkWidget hexpand property. Therefore, we can get the sliders back to the way they were in 3.8 by setting hexpand to TRUE. http://bugzilla.gnome.org/show_bug.cgi?id=708493
Review of attachment 255452 [details] [review]: Looks good to me, just one minor nitpick -- I'd swap the "adjustment" and "hexpand" lines everywhere. Glades saves them the other way around, so that "hexpand" comes first and "adjustment" second. Doing it the same way here would avoid needless changes in the future when someone resaves the ui file.
Review of attachment 255452 [details] [review]: The buttons were broken. Now they are fixed. They look awesome too! Thanks for your contribution.
Review of attachment 255452 [details] [review]: Sliders now though they used to look a lot like buttons until they were fixed to properly slide across the width of the panel like they should do. That's all I have to say. A very welcome fix. The sooner the better.
Attachment 255452 [details] pushed as 03212c0 - universal access: Fix non-expanding sliders in zoom options
(In reply to comment #5) Works for me. Thanks, Matthias. (I realize the patch has been committed, but I thought that being the reporter, I should say something).