After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708181 - Wayland: Wrap X11 specific gdk calls
Wayland: Wrap X11 specific gdk calls
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
: 707254 (view as bug list)
Depends on:
Blocks: wayland
 
 
Reported: 2013-09-16 18:29 UTC by Armin K.
Modified: 2015-02-14 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wrap gdk_x11_* calls with runtime and compile checks (3.07 KB, patch)
2013-09-16 18:29 UTC, Armin K. 		committed Details | Review

Description Armin K. 2013-09-16 18:29:11 UTC 
Created attachment 255059 [details] [review]
wrap gdk_x11_* calls with runtime and compile checks

https://wiki.gnome.org/Wayland#Porting_GNOME_to_Wayland
Comment 1 c.herbig 2013-09-23 03:30:03 UTC 
This is the same type of problem as in 707254. Glad to know I'm not the only one who has run into this issue.  Before trying the following, I was able to get the same solution you used to work successfully with gtk3-quartz on OS X. However, after browsing through the documentation, I eventually came up with the following:

What worked for me was to replace all <gdk/gdkx.h> with <gdk/gdk.h>, and the gdk_x11_* calls with 
gtk_window_present_with_time (GTK_WIDGET (window), GDK_CURRENT_TIME);

I found the that here: https://developer.gnome.org/gdk3/stable/gdk3-Events.html

I don't have available any environment other than gtk3-quartz to test it with though, so although it seems to work fine for me, I can't say if that is the best solution; I'm also not really a Gtk programmer.
Comment 2 Matthias Clasen 2013-12-06 00:45:21 UTC 
The patch works fine in my testing, can we get it committed ?
Comment 3 Shaun McCance 2013-12-06 14:22:46 UTC 
The xid is used for the PackageKit calls to attach the PK dialogs to the Yelp window. Is this doable in Wayland? What's the current best practice?
Comment 4 Matthias Clasen 2013-12-06 17:10:06 UTC 
(In reply to comment #3)
> The xid is used for the PackageKit calls to attach the PK dialogs to the Yelp
> window. Is this doable in Wayland? What's the current best practice?

No. However, it is not a great experience in X, and the general idea for evolving this addon functionality is to move away from these 'outer-body' attached dialogs, and instead require applications to provide proper UI if they want to sort of functionality.
Comment 5 Matthias Clasen 2014-04-11 21:48:49 UTC 
ping ? would still be nice to get the patch merged
Comment 6 David King 2015-02-14 15:17:40 UTC 
*** Bug 707254 has been marked as a duplicate of this bug. ***