After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707114 - Wrong password when extracting ZIP archive : no warning
Wrong password when extracting ZIP archive : no warning
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-30 07:38 UTC by tarnyko
Modified: 2013-09-02 19:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
file-roller_zipwrongalert.patch (1.59 KB, patch)
2013-08-30 07:38 UTC, tarnyko
none Details | Review

Description tarnyko 2013-08-30 07:38:44 UTC
Created attachment 253585 [details] [review]
file-roller_zipwrongalert.patch

When extracting a password-protected ZIP archive, and providing the wrong password, file-roller doesn't show any warning (whereas "unzip", which it uses for the extraction task, does in the same case).

This may mislead the user, who has to find out why the extracted folders are empty.

Please consider the attached patch, which fixes this behavior.

(Before :
http://www.tarnyko.net/repo/fileroller01.png
After :
http://www.tarnyko.net/repo/fileroller02.png)
Comment 1 Paolo Bacchilega 2013-09-01 07:22:38 UTC
there is no need to create a new error type, just use FR_ERROR_ASK_PASSWORD and file-roller will ask the user to enter a new password.
Comment 2 Paolo Bacchilega 2013-09-02 19:21:28 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.