GNOME Bugzilla – Bug 70617
Allow single exec of many queries in SQL Window
Last modified: 2012-02-28 11:58:15 UTC
Introuction =========== I have several feature requests (enhancements) for the wonderful gnomedb-fe included with gnome-db. Feature 1 - Multiple-Query/Single-Execution feature =================================================== Can the SQL Window in gnomedb-fe be modified to include multiple queries but only execute the hi-lighted SQL statement or execute SQL statement wherever the cursor lies between lines that contain a semicolon? Currently, the SQL Window screen only executes the last SQL statement where each SQL statement is separated by a semicolon or maybe it executes all of them -- but only the output shows the last query executed. I believe the later to be true. Below, I give an example of the multiple-query/single-execution feature I'm interested in: 1 SELECT 'Query A' (if cursor on this line - Query A will execute) 2 FROM TABLEA; (if cursor on this line - Query A will execute) 3 (if cursor on this line - No query will execute???) 4 SELECT 'Query B' (if cursor on this line - Query B will execute) 5 FROM TABLEB; (if cursor on this line - Query B will execute) 6 (if cursor on this line - No query will execute???) 7 SELECT 'Query C' (if cursor on this line - Query C will execute) 8 (if cursor on this line - Query C will execute) 9 FROM TABLEC (if cursor on this line - Query C will execute) 10 ; (if cursor on this line - Query C will execute) 11 SELECT 'Query D' (if cursor on this line - Query D will execute) 12 FROM TABLED; (if cursor on this line - Query D will execute) Feature 2 - Query Execution Modes: Batch/Single =============================================== There are two execution modes I'm interested in the SQL Window having. 1. Executing one SQL Statement like I mentioned above 2. Executing a Batch of SQL Statements like it currently does. The execution would start either at the beginning of the SQL Window or the line the cursor is located. This can be a user preference. Feature 3 - Two Buttons for Query Execution =========================================== Currently, there is one button for execution of a query. Another button can be added. One button would be for single query execution and the other button would be for batch query execution. Feature 4 - Error Handling of Query Execution ============================================= If an error occurs, stop executing anymore SQL statements, log the error, position the cursor at the SQL statement that caused the error, and pop up an error message. Preferences by a user could be done here. Feature 5 - Logging Output using a Textbox ========================================== It would also be nice to have the ability to log query output to a GtkText multi-line textbox instead of a table. Of course, word-wrapping and line-wrapping would be turned off so you could display a table row on one line which has many columns. Preferences could be done here too. A user may prefer the query output over the textbox log output. The user may also prefer the textbox output, but clear the textbox before each query is executed. The logging includes the execution of DDL too. However, for DDL, only the SQL statement keywords have to be logged. Execution of the SQL statement: CREATE USER joe WITH PASSWORD 'string'; Would result in this in the textbox log output: CREATE USER Conclusion ========== Anyways, these are just some of my ideas for the SQL Window in the GnomeDB Frontend application. Request For Comment is welcomed.
I have an additional feature request (enhancement). Feature 6 - Keyboard Shortcuts for Feature 3 ============================================ Allow the user to immediately execute the single query by a key shortcut, such as, F5, Shift-F5, or Ctrl-Enter. This way a user doesn't have to keep going back and forth between typing his/her queries clicking on the 'Execute Batch Query' or 'Execute Single Query' buttons. F5 or Ctrl-Enter could be used for the execution of a single query. Shift-F5 could be used for the execution of a batch of queries at the current cursor location. Of course, these keyboard shortcuts could be a user preference settable in the Preferences dialog which is found by clicking on menu Tools - Settings.
After a long discussion with Rodrigo Moya on IRC channel #gnome-db at irc.gnome.org, I have additional info for this bug (enhancement). See the message thread in the gnome-db-list at: http://mail.gnome.org/archives/gnome-db-list/2002-March/msg00036.html Subject: Gnome-DB SQL Window syntax hi-lighting of keywords According to Rodrigo, to add a Toolbar button and menu items to gnome-db, look at: gnome-db/ui/*.xml Those files are loaded for each component. In those files, you define a 'verb' for each command.(menu/toolbar item). And then, in your code, you use a BonoboUIVerb array to specify which function implements each verb. In gnome-db/components/database/components-database.c you've got that code. The nice thing of those XML files is that you can modfiy the UI without recompiling. And it's more flexible than creating the menus/toolbars by hand. As you see, you just specify (in BonoboUIVerb's) the verb and the function pointer. And then, in the function pointer, you do the implementation. And for associating that XML file with a control, you use gnome_db_control_set_ui. To add a keyboard shortcut, you add them to the .xml files, in gnome-db/ui There is a property for <cmd></cmd> to specify it. gnome-db-database.xml contains some keyboard shortcuts. If you add a Bonobo verb, you also need to add it to the BonoboUIVerb struct.
Things to still to do: ===================== - code clean up the syntax hi-lighting for SQL keywords, comments, and string constants. - split of the text buffer into multiple queries, and execute one command at a time. Make this simple using g_strsplit with the split by ; (semicolon). - instead of 1 button for executing the SQL commnds -- how about 3 buttons: 1. execute the command at the current cursor location 2. execute commands starting at the current cursor location 3. execute all the commandsz - add keyboard shortcuts for the 3 buttons above (changeable by user preference): 1. F5 2. Shift-F5 3. Alt-F5 - elegant error handling for when a SQL Error occurs on execution of one of the commands
I still would like this feature to be implemented. However, the GNOME-DB front-end has been replaced by Mergeant. The SQL Editor in libgnomedb as GnomeDbSqlEditor has been replaced by GnomeDbEditor. The new GnomeDbEditor uses a gtksourceview for its syntax high lighting. This feature (bug) is important for real work, such as, loading a file into the SQL buffer which contains many SQL statements which will need to be executed. Because, a SQL error can occur, the user needs to be able to edit the offending SQL statement that caused the error, and then continue first with the SQL statement which failed. For instance, let's say you had a script that created table in an Oracle database in tablespace TABSPC1, but the database you are now running this script on only has a tablespace named TABSPC2, you will get an error. This feature will allow you to correct the CREATE TABLE command and then continue with the rest of the SQL statements.
mergeant development has been stalled and it has been unmaintained for a few years now. Maintainers don't have future development plan so i am closing bugs as WONTFIX. Please feel free to reopen the bugs in future if anyone takes the responsibility for active development.