After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705683 - [srtp] invalid packets results in GST_FLOW_ERROR
[srtp] invalid packets results in GST_FLOW_ERROR
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Windows
: Normal normal
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-08 15:46 UTC by Morgan Lindqvist
Modified: 2013-08-12 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morgan Lindqvist 2013-08-08 15:46:30 UTC 
The gst_srtp_dec_chain() function in gstsrtpdec.c returns GST_FLOW_ERROR is the SRTP library fails to decode the received packet.

http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/srtp/gstsrtpdec.c#n916

This will make the code very intolerant towards stray packets, DoS attacks and errors in the packets. Would it not be better if the packet was dropped in the same way as the RTP stack drops packets that are not RTP packets?
Comment 1 Olivier Crête 2013-08-12 15:57:20 UTC 
commit 04bd37dd676a1f91f5669af65619c82c304db7f9
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Mon Aug 12 11:56:27 2013 -0400

    srtpdec: Don't error on invalid packet, just drop it