After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705412 - hi-dpi support: include @2 scaled icons
hi-dpi support: include @2 scaled icons
Status: RESOLVED WONTFIX
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2013-08-03 14:40 UTC by Matthias Clasen
Modified: 2014-09-02 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
modified render-icon-theme.py (5.53 KB, text/x-python)
2013-08-14 10:17 UTC, Andreas Nilsson
  Details
bash script for outputting the stock icons @2x (299 bytes, application/x-shellscript)
2013-08-14 14:51 UTC, Andreas Nilsson
  Details
Render icons at 2x for HiDPI displays (7.76 KB, patch)
2013-08-19 19:52 UTC, Alexander Larsson
none Details | Review
Example with re-rendered icons (34.47 KB, image/png)
2013-08-19 20:08 UTC, Alexander Larsson
  Details
Example with just letting gtk+ pick larger icons (34.73 KB, image/png)
2013-08-19 20:09 UTC, Alexander Larsson
  Details

Description Matthias Clasen 2013-08-03 14:40:36 UTC
Some (all ?) icons should be available in an @2 scaled version for use on hi-dpi displays.
Comment 1 Andreas Nilsson 2013-08-13 09:41:16 UTC
I spoke briefly to Alex about this at GUADEC, he believed it might work to just export the icons at 180 instead of 90 in Inkscape, so I wanted to test that.

The result is available here: https://cloud.gnome.org/public.php?service=files&t=3191b5cd394734e43afd3cea956149a0 (too big to attach to bugzilla I believe).

I've named these user-bookmarks@2x.png etc. similar to how qt5 and osx names their icons and placed those in their respective folders next to the regular sizes. Is this naming and placement correct?

Some icons exported a bit weird, such as the emotes in 32 and 48, and the folder icons in 48. Other icons just had bitmaps pasted into the svg source for 16 and 24, so they ended up blurry due to that. However, this should work to at least test this approach with and then we can revisit the few icons that currently look weird.
Comment 2 Matthias Clasen 2013-08-13 14:38:33 UTC
I think alex' idea was to put these icons into separate 48x48@2/ directories, and add those to the index.theme with some metadata. Lets wait for alex to come back from vacation. Thanks for the icons, anyway !
Comment 3 Andreas Nilsson 2013-08-13 14:46:26 UTC
Should be easy to tweak the theme to just do that. Is he back before ui-freeze?
Comment 4 Matthias Clasen 2013-08-13 20:51:02 UTC
He's back next week, I think. In any case, we need gtk patches to make use of these icons when appropriate.
Comment 5 Andreas Nilsson 2013-08-14 10:15:48 UTC
Here with folder names like 48x48@2x etc.
https://cloud.gnome.org/public.php?service=files&t=ab22f0963bc810fc11ff19e4bbceb657
Comment 6 Andreas Nilsson 2013-08-14 10:17:25 UTC
Created attachment 251594 [details]
modified render-icon-theme.py

Here are the crude modifications to render-icon-theme.py. Needs to accommodate rendering the regular ones and the *@2x folders but that is way above my level of programming :)
Comment 7 Andreas Nilsson 2013-08-14 14:50:02 UTC
And here are the stock icons for gtk @2x
https://cloud.gnome.org/public.php?service=files&t=f09e1faf657175d062e62819db676163
Comment 8 Andreas Nilsson 2013-08-14 14:51:01 UTC
Created attachment 251618 [details]
bash script for outputting the stock icons @2x
Comment 9 Jakub Steiner 2013-08-19 19:40:09 UTC
The only thing I would do about hidpi would be to render hidef at 512px instead of 256px, but I really don't feel rendering lowres icons @2 is worth the price.
Comment 10 Alexander Larsson 2013-08-19 19:52:18 UTC
Created attachment 252281 [details] [review]
Render icons at 2x for HiDPI displays
Comment 11 Alexander Larsson 2013-08-19 20:08:44 UTC
Created attachment 252283 [details]
Example with re-rendered icons
Comment 12 Alexander Larsson 2013-08-19 20:09:14 UTC
Created attachment 252284 [details]
Example with just letting gtk+ pick larger icons
Comment 13 Alexander Larsson 2013-08-19 20:14:32 UTC
I just attached example screenshots at scale 2, with gtk3-demo showing 24x24 toolbar icons either with 24x24@2 re-rendered svgs or just picking the old 48x48 icons. IMHO the old 48x48 icons look better, so maybe its a bad idea to do this.

Sizes 16 and 24 have natural double sized icons at 32 and 48. 22 is not really used. For 48 at scale 2 we're probably ok with the 256 icons scaled down to 96x96. Unsure about size 32, it will currently pick the 256x256 icons and scale them down to 64x64, not sure if thats good enough.

I think maybe we should leave things as is and instead only add Scale=2 directories if we find any particular icon that needs to be custom-drawn for scale 2.
Comment 14 Jakub Steiner 2014-09-02 14:43:42 UTC
I agree we get better results in using higher detail variants than double-resolution rendering lowers size assets. Closing as wontfix