After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703067 - planner should rely on GNOME_COMPILE_WARNINGS macro instead of its own PLANNER_COMPILE_WARNINGS
planner should rely on GNOME_COMPILE_WARNINGS macro instead of its own PLANNE...
Status: RESOLVED OBSOLETE
Product: planner
Classification: Other
Component: Build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-25 16:35 UTC by Pacho Ramos
Modified: 2021-06-03 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use GNOME_COMPILE_WARNINGS (545 bytes, patch)
2015-01-14 00:21 UTC, Ahmed Baïzid
none Details | Review
Remove PLANNER_COMPILE_WARNING (2.35 KB, patch)
2015-01-14 00:31 UTC, Ahmed Baïzid
none Details | Review
Use AX_COMPILER_FLAGS instead of PLANNER_COMPILE_WARNINGS. (947 bytes, patch)
2017-06-01 21:19 UTC, Ahmed Baïzid
none Details | Review
Use AX_COMPILER_FLAGS instead of PLANNER_COMPILE_WARNINGS. (837 bytes, patch)
2017-06-04 14:07 UTC, Ahmed Baïzid
none Details | Review

Description Pacho Ramos 2013-06-25 16:35:11 UTC
For consistency with the rest of gnome related packages, that use macro provided by gnome-common:
https://git.gnome.org/browse/gnome-common/tree/macros2/gnome-compiler-flags.m4

Thanks
Comment 1 Ahmed Baïzid 2015-01-14 00:21:49 UTC
Created attachment 294479 [details] [review]
Use GNOME_COMPILE_WARNINGS
Comment 2 Ahmed Baïzid 2015-01-14 00:31:34 UTC
Created attachment 294480 [details] [review]
Remove PLANNER_COMPILE_WARNING
Comment 3 Ahmed Baïzid 2015-01-14 00:33:48 UTC
I agree Pacho Ramos.

This is a little step towards GTK+ 3.

And, magic: It solves bug 742488.
Comment 4 Pacho Ramos 2015-01-14 15:28:04 UTC
Looks like at the present we should use AX_COMPILER_FLAGS macro instead -> bug 729407
Comment 5 Ahmed Baïzid 2015-01-16 00:02:28 UTC
I'm with you.
However, AX_COMPILER_FLAGS is too recent for Planner...

I tried to use it.
AX_COMPILER_FLAGS is not in the autoconf archive of Debian Unstable. I copied it. Its true place is in m4 directory. All GNOME projects have one, except (bug 742998). So I pasted it into acinclude.m4. I have not been able to compile Planner. Warnings are mistakes ...
This is too much change for very little benefit.

Use GNOME_COMPILE_WARNINGS is simpler (attachment 294479 [details] [review]). It does not consider warnings as errors, I can make Planner.

GNOME_COMPILE_WARNINGS is an excellent first step towards AX_COMPILER_FLAGS. 
Within months AX_COMPILER_FLAGS be commonplace ans Planner will have no warning. Switching will be as easy as:
    $ sed -e 's / GNOME_COMPILE_WARNINGS / AX_COMPILER_FLAG /' configure.ac
This is, I think, another bug.
Comment 6 Ahmed Baïzid 2017-06-01 21:19:59 UTC
Created attachment 353034 [details] [review]
Use AX_COMPILER_FLAGS instead of PLANNER_COMPILE_WARNINGS.

Two years later AX_COMPILER_FLAGS became regular stuff.

Pacho Ramos Comment 5 is more reasonable than ever.

How the build goes ?

More warnings appear.

Since warnings are errors, a simple `make` fails.

One has to configure with `enable-compile-warnings` set to `yes` or `no` but no `error`, the default.

This is what I added to Makefile.am.
Comment 7 Ahmed Baïzid 2017-06-04 14:07:31 UTC
Created attachment 353142 [details] [review]
Use AX_COMPILER_FLAGS instead of PLANNER_COMPILE_WARNINGS.

I simplified the patch.

The configuration follows the "minor version" policy to state if the code is a release. Compiler errors and debug features are then disabled. The current version is 0.14.6. The minor version is even. The build continues despite the warnings...


One day, developers will take branch 0.15.0 to change the code. No warning will be allowed. And this severe policy might be good. The code entering the repository must not issue any warning. A whole lotta job...

Source : https://wiki.gnome.org/Initiatives/GnomeGoals/ModernAutotools
Comment 8 Mart Raudsepp 2021-06-03 17:42:53 UTC
Planner uses meson now instead, making this bug here obsolete