After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702809 - gnome-font-viewer doesn't support the standard --help and --version options
gnome-font-viewer doesn't support the standard --help and --version options
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-21 11:53 UTC by Laurent Bigonville
Modified: 2014-10-26 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (2.62 KB, patch)
2014-02-08 11:39 UTC, Arnaud B. 		reviewed Details | Review
patch with EXIT_FAILURE (2.92 KB, patch)
2014-02-09 03:38 UTC, Arnaud B. 		accepted-commit_now Details | Review

Description Laurent Bigonville 2013-06-21 11:53:19 UTC 
Hi,

From the debian BTS: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674710

=====8<=====

gnome-font-viewer doesn't support the standard --help and --version
options: it tries to open a --help or --version file. Given the fact
that a man page isn't provided either, it is not possible to get any
documentation.

=====8<=====
Comment 1 Arnaud B. 2014-02-08 11:39:45 UTC 
Created attachment 268482 [details] [review]
proposed patch

Newbie in C & patching here! No idea if I’ve done things correctly, but looks like the code works.
Comment 2 Cosimo Cecchi 2014-02-08 20:58:29 UTC 
Review of attachment 268482 [details] [review]:

Thanks, this looks mostly good. Just two little style nitpicks below.

::: src/font-view.c
@@ +933,3 @@
+        g_option_context_free (ctx);
+
+        /* I18N: The '%s' is replaced with the command name. */

Should probably return EXIT_FAILURE here instead

@@ +934,3 @@
+
+        return 1;
+        help_msg = g_strdup_printf (_("Run '%s --help' to see a full "

Weird indentation for this closing bracket
Comment 3 Arnaud B. 2014-02-09 03:38:31 UTC 
Created attachment 268545 [details] [review]
patch with EXIT_FAILURE

Like that? By the way, there are some parts of the file that use many tabs, instead of spaces. Is that a good idea to correct that? and in the same patch or in another?
Comment 4 Robert Roth 2014-10-25 19:48:55 UTC 
@Cosimo Cecchi: could you please follow up on comment 2?
Comment 5 Cosimo Cecchi 2014-10-26 16:44:35 UTC 
Review of attachment 268545 [details] [review]:

Looks good to me
Comment 6 Robert Roth 2014-10-26 18:28:43 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.