After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701046 - rtspsrc: parse SDP framerate and dimension attributes
rtspsrc: parse SDP framerate and dimension attributes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal blocker
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-26 13:30 UTC by Sebastian Rasmussen
Modified: 2013-05-31 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for adding parsing of SDP attributes (3.51 KB, patch)
2013-05-26 13:32 UTC, Sebastian Rasmussen
none Details | Review
2nd proposed patch for adding parsing of SDP attributes (3.51 KB, patch)
2013-05-26 16:45 UTC, Sebastian Rasmussen
none Details | Review

Description Sebastian Rasmussen 2013-05-26 13:30:01 UTC
I recently contributed a few patches adding support for a=framerate, a=framesize and a=x-dimensions in gst-rtsp-server, rtpjpegpay/depay and rtph264pay/depay.

This patch adds the corresponding parsing in rtspsrc, namely that it parses the SDP attributes and converts these to relevant caps attributes for use by the depayloaders.
Comment 1 Sebastian Rasmussen 2013-05-26 13:32:29 UTC
Created attachment 245329 [details] [review]
Proposed patch for adding parsing of SDP attributes
Comment 2 Sebastian Dröge (slomo) 2013-05-26 15:17:26 UTC
Looks good but shouldn't there be some sanity checks for the values parsed from the strings?
Comment 3 Sebastian Rasmussen 2013-05-26 16:45:18 UTC
Created attachment 245342 [details] [review]
2nd proposed patch for adding parsing of SDP attributes
Comment 4 Wim Taymans 2013-05-27 13:17:18 UTC
This patch is not right IMO:

- those attributes are already converted from the SDP to the application/x-rtp caps by prepending all attributes with a- or x- so that the depayloaders can pick them up.
- we don't want to mix non-rtp properties in application/x-rtp
Comment 5 Sebastian Dröge (slomo) 2013-05-28 06:54:14 UTC
Wim, Sebastian and Olivier are currently trying to agree on a solution for this... must be fixed or reverted before 1.2
Comment 6 Sebastian Rasmussen 2013-05-28 10:02:43 UTC
Actually this applies not just to this bug, but to 700747, 700748 and 700749 as well. I will attach revert-patches for this mess later today. I hope that they'll be merged soon.
Comment 7 Wim Taymans 2013-05-31 13:50:10 UTC
Should be all reverted now. One fix to rtsp-sdp:

commit cfdf2e6db53ece4456bd1594d66ca9f80c204c59
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri May 31 15:41:55 2013 +0200

    rtsp: place a- and x- properties as attributes
    
    application/x-rtp has properties with a- and x- prefixes that should be
    placed as attributes in the SDP for the media instead of being added to the
    fmtp.


This takes the a-framerate and a-framesize from the jpeg payloader and places them in the SDP. rtspsrc will prefix all media attributes with a- again and the depayloader picks them up and sets them as framerate and width/height on the output caps.