GNOME Bugzilla – Bug 701046
rtspsrc: parse SDP framerate and dimension attributes
Last modified: 2013-05-31 13:50:17 UTC
I recently contributed a few patches adding support for a=framerate, a=framesize and a=x-dimensions in gst-rtsp-server, rtpjpegpay/depay and rtph264pay/depay. This patch adds the corresponding parsing in rtspsrc, namely that it parses the SDP attributes and converts these to relevant caps attributes for use by the depayloaders.
Created attachment 245329 [details] [review] Proposed patch for adding parsing of SDP attributes
Looks good but shouldn't there be some sanity checks for the values parsed from the strings?
Created attachment 245342 [details] [review] 2nd proposed patch for adding parsing of SDP attributes
This patch is not right IMO: - those attributes are already converted from the SDP to the application/x-rtp caps by prepending all attributes with a- or x- so that the depayloaders can pick them up. - we don't want to mix non-rtp properties in application/x-rtp
Wim, Sebastian and Olivier are currently trying to agree on a solution for this... must be fixed or reverted before 1.2
Actually this applies not just to this bug, but to 700747, 700748 and 700749 as well. I will attach revert-patches for this mess later today. I hope that they'll be merged soon.
Should be all reverted now. One fix to rtsp-sdp: commit cfdf2e6db53ece4456bd1594d66ca9f80c204c59 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Fri May 31 15:41:55 2013 +0200 rtsp: place a- and x- properties as attributes application/x-rtp has properties with a- and x- prefixes that should be placed as attributes in the SDP for the media instead of being added to the fmtp. This takes the a-framerate and a-framesize from the jpeg payloader and places them in the SDP. rtspsrc will prefix all media attributes with a- again and the depayloader picks them up and sets them as framerate and width/height on the output caps.