GNOME Bugzilla – Bug 700006
audio/video: base classes have suboptimal error handling when allocating a buffer not via a bufferpool
Last modified: 2013-05-24 15:26:53 UTC
See summary, problem is that just NULL is returned and the subclasses a) expect always to get a buffer currently and b) there's no way to report errors properly here (are we flushing? did negotiation fail? what happened?) Related to bug #699124
commit b8c6413a8efebd2272eb98171f3dcf936c20ae0b Author: Sebastian Dröge <slomo@circular-chaos.org> Date: Fri May 24 16:52:50 2013 +0200 audio: Always provide a buffer in gst_audio_(enc|dec)oder_allocate_output_buffer() We have no way of tell the caller of the exact error (e.g. if we're flushing), so will have to wait until the caller uses API that returns a GstFlowReturn, for example when pushing this buffer. https://bugzilla.gnome.org/show_bug.cgi?id=700006 commit 0c2c909497f5f97074cf1b0d26bd14939f892b6f Author: Sebastian Dröge <slomo@circular-chaos.org> Date: Fri May 24 16:51:17 2013 +0200 video: Always provide a buffer in gst_video_(enc|dec)oder_allocate_output_buffer() We have no way of tell the caller of the exact error (e.g. if we're flushing), so will have to wait until the caller uses API that returns a GstFlowReturn, for example when pushing this buffer. https://bugzilla.gnome.org/show_bug.cgi?id=700006