After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699915 - Selection pattern design updates
Selection pattern design updates
Status: RESOLVED OBSOLETE
Product: gnome-weather
Classification: Applications
Component: design
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
3.10
Depends on: 706815
Blocks:
 
 
Reported: 2013-05-08 09:23 UTC by Allan Day
Modified: 2014-08-27 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Allan Day 2013-05-08 09:23:12 UTC
There's been a round of changes to the selection pattern; these are intended to
overcome a bunch of issues that we've encountered with the existing design.

Details of the updated design can be found here:

https://live.gnome.org/GnomeOS/Design/Whiteboards/SelectionPattern
Comment 1 Giovanni Campagna 2013-05-12 15:03:26 UTC
Sorry for taking so long to answer.

I looked at the wiki page, but I did not see what specific changes are requested here.
In particular, we already support rubberbanding, using the latest revision of GdMainView, and that's what I see changed from earlier patterns.

In any case, first we need a GdMainView (or EggFlowBox) supporting the pattern in libgd or even better in gtk+.
Comment 2 Allan Day 2013-05-13 10:13:15 UTC
Hey Giovanni! I've added some notes to the wiki page which describe how it changes from the existing selection pattern.

Do we have bugs for the Gtk/libgd issues that you mention? It would be good to be able to track those as we move towards the latest iteration of the selection mode.
Comment 3 Giovanni Campagna 2013-05-13 21:26:28 UTC
Ok, there was a lot of stuff I hadn't noticed and required changed in gnome-weather.

I now implemented the following points:
* Use a standard toolbar at the bottom rather than an overlaid toolbar
* Label action items with strings rather than icons
* Use a "Cancel" button in the toolbar rather than "Done"
* Close selection mode once an action is performed (rather than leaving it open)

The remaining one:
* Additional ways to activate selection mode (ctrl+click, long press, rubberband selection, etc)
needs to be tackled in libgd, but seems to be mostly fine already.
Comment 4 Giovanni Campagna 2013-05-13 21:26:28 UTC
Ok, there was a lot of stuff I hadn't noticed and required changed in gnome-weather.

I now implemented the following points:
* Use a standard toolbar at the bottom rather than an overlaid toolbar
* Label action items with strings rather than icons
* Use a "Cancel" button in the toolbar rather than "Done"
* Close selection mode once an action is performed (rather than leaving it open)

The remaining one:
* Additional ways to activate selection mode (ctrl+click, long press, rubberband selection, etc)
needs to be tackled in libgd, but seems to be mostly fine already.
Comment 5 Debarshi Ray 2013-08-05 09:25:05 UTC
Ctrl+click and rubberband selection should already work in current libgd. eg., look at Documents.

I don't know about long press. Is it supposed to be a touch thing?

Regarding shift+click, the design says: "shift+click allows ranges of items to be selected". Is that somehow different from the way ctrl+click works at the moment? Or should ctrl+click and shift+click work indentically?
Comment 6 Matthias Clasen 2013-08-20 12:38:23 UTC
The usual distinction between Ctrl-click and Shift-click is that Ctrl lets you add and remove individual items from the current selection, whereas Shift always adds the range between the selection start and the clicked item. How the 'selection start' point gets updated as you interact with the selection varies and can be a bit confusing.
Comment 7 Debarshi Ray 2013-08-20 19:29:49 UTC
(In reply to comment #6)
> The usual distinction between Ctrl-click and Shift-click is that Ctrl lets you
> add and remove individual items from the current selection, whereas Shift
> always adds the range between the selection start and the clicked item.

Yes, but that distinction gets blurry due to the way the current selection pattern works:
(1) The rubberband selection is started with ctrl+click/drag, which is sort of what we think shift+click should do.
(2) You can go ctrl+clicking or right clicking individual items to get them selected.

Or am I missing something?
Comment 8 Matthias Clasen 2013-09-03 12:02:48 UTC
I think this no longer needs to be on the blocker list; the bulk of it is done
Comment 9 Giovanni Campagna 2014-08-27 14:22:13 UTC
The new design does not have a selection mode, closing.