After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699914 - Selection pattern design updates
Selection pattern design updates
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
3.10
Depends on:
Blocks:
 
 
Reported: 2013-05-08 09:21 UTC by Allan Day
Modified: 2013-08-08 10:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
selection-toolbar: Implement the new selection toolbar (17.02 KB, patch)
2013-08-07 00:35 UTC, Debarshi Ray
none Details | Review
main-toolbar: Use a "Cancel" button instead of "Done" (1.12 KB, patch)
2013-08-07 00:36 UTC, Debarshi Ray
committed Details | Review
selection-toolbar: Exit the mode when an action has been performed (5.23 KB, patch)
2013-08-07 00:37 UTC, Debarshi Ray
committed Details | Review
selection-toolbar: Implement the new selection toolbar (17.49 KB, patch)
2013-08-08 10:06 UTC, Debarshi Ray
committed Details | Review

Description Allan Day 2013-05-08 09:21:05 UTC
There's been a round of changes to the selection pattern; these are intended to
overcome a bunch of issues that we've encountered with the existing design.

Details of the updated design can be found here:

https://live.gnome.org/GnomeOS/Design/Whiteboards/SelectionPattern
Comment 1 Debarshi Ray 2013-08-07 00:35:43 UTC
Created attachment 251009 [details] [review]
selection-toolbar: Implement the new selection toolbar
Comment 2 Debarshi Ray 2013-08-07 00:36:17 UTC
Created attachment 251010 [details] [review]
main-toolbar: Use a "Cancel" button instead of "Done"
Comment 3 Debarshi Ray 2013-08-07 00:37:00 UTC
Created attachment 251011 [details] [review]
selection-toolbar: Exit the mode when an action has been performed
Comment 4 Debarshi Ray 2013-08-07 00:44:16 UTC
The wiki does not cover cases where the action is a toggle. eg., the favorite button. I have left it as an icon because:

- It is a bit strange to flip between "Mark as Favorite" and "Unmark as Favorite" because the state of the button and the colour of the icon already implies the mark / unmark action.

- The toolbar starts getting cluttered. We already have "Open with Image Viewer" and "Add to Album". In future we will have "Share".

- The designs in https://wiki.gnome.org/Design/Apps/Photos use an icon for favorites (well, it uses a star instead of a heart) while using labels for others.

What do you think?
Comment 5 Jakub Steiner 2013-08-07 09:52:51 UTC
(In reply to comment #4)

> What do you think?

Agreed. The metaphor is widely used and will be clear I think.
Comment 6 Debarshi Ray 2013-08-08 10:06:53 UTC
Created attachment 251131 [details] [review]
selection-toolbar: Implement the new selection toolbar