After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 699447 - v4l2: try to allocate new buffers with VIDIOC_CREATE_BUFS if needed
v4l2: try to allocate new buffers with VIDIOC_CREATE_BUFS if needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-02 09:32 UTC by Michael Olbrich
Modified: 2013-05-03 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.04 KB, patch)
2013-05-02 09:32 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2013-05-02 09:32:39 UTC 
Created attachment 243024 [details] [review]
patch

If max_buffers is 0 then an arbitrary number of buffers (currently 4) is
allocated. If this is not enough v4l2src starts copying buffers.
With this patch VIDIOC_CREATE_BUFS is used to allocate a new buffer. If
this fails v4l2src falls back to copying buffers.
Comment 1 Sebastian Dröge (slomo) 2013-05-03 09:13:53 UTC 
This should also help the sink if I'm not missing anything, at least if the sink is providing buffers to upstream.

commit de5a63bb0999aa72a152b82ed349ec129a79358a
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Thu May 2 09:41:01 2013 +0200

    v4l2: try to allocate new buffers with VIDIOC_CREATE_BUFS if needed
    
    If max_buffers is 0 then an arbitrary number of buffers (currently 4) is
    allocated. If this is not enough v4l2src starts copying buffers.
    With this patch VIDIOC_CREATE_BUFS is used to allocate a new buffer. If
    this fails v4l2src falls back to copying buffers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699447