After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697550 - clock: Winpthreads compatibility
clock: Winpthreads compatibility
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-08 12:00 UTC by LRN
Modified: 2013-04-09 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Also check for clock_gettime in libpthread (957 bytes, patch)
2013-04-08 12:01 UTC, LRN
committed Details | Review

Description LRN 2013-04-08 12:00:55 UTC
libwinpthreads (from mingw-w64 project) has POSIX clock functions (clock_gettime and clock_getres). They could be used in GStreamer.
Comment 1 LRN 2013-04-08 12:01:34 UTC
Created attachment 240941 [details] [review]
Also check for clock_gettime in libpthread
Comment 2 Sebastian Dröge (slomo) 2013-04-09 18:25:05 UTC
Review of attachment 240941 [details] [review]:

::: configure.ac
@@ +461,3 @@
+  ], [
+    AC_CHECK_LIB(pthread, clock_gettime, [
+      AC_DEFINE(HAVE_CLOCK_GETTIME, 1)

That #define is used nowhere :) The patch is correct of course but without using that #define somewhere in the code it feels a bit useless.

Could you combine this with the POSIX_TIMERS stuff that is checked/defined below?
Comment 3 Sebastian Dröge (slomo) 2013-04-09 18:35:27 UTC
Nevermind, that was in your other bug already ;)

commit e2f2ee3582731fd52e5b93a0a82fdf6f4156bce2
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Mon Apr 8 13:14:35 2013 +0400

    configure: Also check for clock_gettime in libpthread
    
    libwinpthreads provides POSIX time API.
    It also provides libpthread alias for itself, for compatibility, so that
    is what we will link with.
    
    Fixes #697550