After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696906 - ac3parse: handle audio/x-private1-ac3 and convert to audio/x-ac3
ac3parse: handle audio/x-private1-ac3 and convert to audio/x-ac3
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-30 13:12 UTC by Christian Fredrik Kalager Schaller
Modified: 2013-05-03 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Fredrik Kalager Schaller 2013-03-30 13:12:39 UTC 
I am not able to intersect for passthrough mode in Transmageddon currently as I get streams with the caps audio/x-private1-ac3 while mpegpsmux wants audio/x-ac3
Comment 1 Christian Fredrik Kalager Schaller 2013-05-02 07:27:47 UTC 
Any chance for a fix for this soon or should I instead aim for a manual workaround in my code?
Comment 2 Sebastian Dröge (slomo) 2013-05-02 07:29:28 UTC 
The workaround in your code should be about as complicated as adding this feature to ac3parse :) But I don't think anybody is working on that or planning to do that in the near future
Comment 3 Andoni Morales 2013-05-02 09:18:39 UTC 
I will be working on it today.
Comment 4 Sebastian Dröge (slomo) 2013-05-03 09:15:43 UTC 
Some work has been started here: https://github.com/ylatuya/gst-plugins-good/commits/audioparse

Looks good to me but would make sense to use gst_structure_has_name() instead of the strcmp() code there. Then ready to push
Comment 5 Tim-Philipp Müller 2013-05-03 09:37:59 UTC 
Did we answer the question if it wouldn't make sense to move this into the demuxer, since it seems specific to the MPEG-PS demuxer only?
Comment 6 Sebastian Dröge (slomo) 2013-05-03 11:05:29 UTC 
Yes, it makes sense to do it there. But due to backwards compatibility and stuff it would also make sense to support it in the parser
Comment 7 Andoni Morales 2013-05-03 11:34:43 UTC 
I have pushed a new branch for 1.0:
https://github.com/ylatuya/gst-plugins-good/commits/audioparse-1.0
Comment 8 Andoni Morales 2013-05-03 11:45:16 UTC 
commit 3462282b83f8bdaa5a1fbfc15eca69e5a2dde1d8
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Thu May 2 15:00:22 2013 +0200

    dcaparse: add support for "audio/x-private1-dts"

commit 4531381541d2e177b458794f9f9ec66d113a0923
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Thu May 2 14:56:02 2013 +0200

    ac3parse: add support for "audio/x-private1-ac3"