GNOME Bugzilla – Bug 696714
wavenc: add 'note' chunk support
Last modified: 2013-04-11 19:00:36 UTC
Created attachment 239969 [details] [review] [PATCH] wavenc: add 'note' chunk support Most of the code TOC support rewritten and improved. Added support 'note' chunk. Not sure about commit message, please fix it.
I'll never be in a hurry, founded small bug...
Created attachment 239972 [details] [review] [PATCH] wavenc: add 'note' chunk support
Created attachment 239999 [details] [review] [PATCH] wavenc: add 'note' chunk support
Review of attachment 239999 [details] [review]: A few small comments. Looks good otherwise. Thanks. ::: gst/wavenc/gstwavenc.c @@ +638,2 @@ static gboolean +gst_wavenc_check_cue_id (guint32 id, GList * list) rename to gst_wavenc_is_cue_id_unique() ? @@ +661,3 @@ + gst_toc_entry_get_start_stop_times (entry, &start, NULL); + + cue = g_new0 (GstWavEncCue, 1); just use g_new(GstWavEncCue, 1); when you initialize all fields @@ +687,3 @@ + return FALSE; + } + return TRUE; here too. @@ +712,3 @@ + } + + if (tags != NULL) { and here too. @@ +855,3 @@ + cues_size += 24; + list = g_list_next (list); + } cues_size += 24 * g_list_length(wavenc->cues); also below.
Created attachment 241288 [details] [review] [PATCH] wavenc: add 'note' chunk support
Review of attachment 241288 [details] [review]: ::: gst/wavenc/gstwavenc.c @@ +859,3 @@ + /* count labls size */ + if (wavenc->labls) { + } else { list = wavenc->labls @@ +870,3 @@ + /* count notes size */ + if (wavenc->notes) { + list = g_list_first (wavenc->labls); list = wavenc->notes
Created attachment 241291 [details] [review] [PATCH] wavenc: add 'note' chunk support Fixed!