After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696429 - wayland: Implement animated cursors
wayland: Implement animated cursors
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-22 23:20 UTC by Matthias Clasen
Modified: 2013-03-28 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Animated cursors 1/3 (4.53 KB, patch)
2013-03-28 13:39 UTC, Chris Cummins
none Details | Review
Animated cursors 2/3 (1.68 KB, patch)
2013-03-28 13:39 UTC, Chris Cummins
none Details | Review
Animated cursors 3/3 (8.19 KB, patch)
2013-03-28 13:40 UTC, Chris Cummins
none Details | Review

Description Matthias Clasen 2013-03-22 23:20:33 UTC
From gdkcursor-wayland.c:

  /* TODO: Do something clever so we can do animated cursors - move the
   * wl_pointer_set_cursor to a function here so that we can do the magic to
   * iterate through
   */
Comment 1 Rob Bradford 2013-03-26 15:24:33 UTC
One of the interns i'm working with has started making progress on this. I'll get him to attach his work for review
Comment 2 Chris Cummins 2013-03-28 13:39:15 UTC
Created attachment 240053 [details] [review]
Animated cursors 1/3
Comment 3 Chris Cummins 2013-03-28 13:39:57 UTC
Created attachment 240054 [details] [review]
Animated cursors 2/3
Comment 4 Chris Cummins 2013-03-28 13:40:31 UTC
Created attachment 240055 [details] [review]
Animated cursors 3/3
Comment 5 Chris Cummins 2013-03-28 14:32:57 UTC
Hi, attached is a proposed implementation for animated cursors. I have also pushed a branch to my GitHub with the patch-set applied:

  https://github.com/ChrisCummins/gtk-.git wip/animated-cursors

Regards,
Chris (le intern)
Comment 6 Kristian Høgsberg 2013-03-28 14:37:18 UTC
Looks good, nice cleanups and straight-forward implementation of animated cursors.  Pushed to master, thanks!
Comment 7 Rob Bradford 2013-03-28 15:57:28 UTC
With the patches integrated let's close the bug!