After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695818 - Disable color management support on !X
Disable color management support on !X
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-14 03:21 UTC by Matthias Clasen
Modified: 2013-03-17 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable color management support on !X (1.61 KB, patch)
2013-03-14 03:21 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2013-03-14 03:21:31 UTC 
The color management support uses X root window properties, and
direct Xlib calls. For now, simply disable this code if we are
not using X11.
Comment 1 Matthias Clasen 2013-03-14 03:21:32 UTC 
Created attachment 238840 [details] [review]
Disable color management support on !X
Comment 2 Felix Riemann 2013-03-16 13:03:38 UTC 
Review of attachment 238840 [details] [review]:

I guess this has to do with Wayland compatibility. Shouldn't we disable the X includes in eog-window.c as well then?

There's probably no equivalent functionality in Wayland yet?
Comment 3 Matthias Clasen 2013-03-17 17:55:36 UTC 
(In reply to comment #2)
> Review of attachment 238840 [details] [review]:
> 
> I guess this has to do with Wayland compatibility. Shouldn't we disable the X
> includes in eog-window.c as well then?

Sure, I've done that now

> There's probably no equivalent functionality in Wayland yet?

Indeed, see https://live.gnome.org/Wayland/Gaps#Color_management
Comment 4 Matthias Clasen 2013-03-17 17:55:52 UTC 
Attachment 238840 [details] pushed as a0cd679 - Disable color management support on !X