After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695141 - Add high contrast icon
Add high contrast icon
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2013-03-04 17:13 UTC by Daniel Mustieles
Modified: 2013-03-08 08:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed HighContrast icon (164.64 KB, image/svg+xml)
2013-03-05 01:45 UTC, Javier Hernández
  Details
Patch including this new icon (360.35 KB, patch)
2013-03-05 01:46 UTC, Javier Hernández
committed Details | Review

Description Daniel Mustieles 2013-03-04 17:13:38 UTC
We are aiming to have an highcontrast app icon for all apps in 3.8.
See https://live.gnome.org/GnomeGoals/HighContrastAppIcons
Comment 1 Javier Hernández 2013-03-05 01:42:45 UTC
Hi!

I am not very good on Inkscape, but I created a HighContrast icon which is very similar to the hicolor one. Anyway, I'll ask for some feedback about it.

Also, I'm attaching a patch which includes this new icon, so I think that this could be ready to push before 3.8.

Cheers,
Javi
Comment 2 Javier Hernández 2013-03-05 01:45:15 UTC
Created attachment 238070 [details]
Proposed HighContrast icon

Proposed icon in SVG format
Comment 3 Javier Hernández 2013-03-05 01:46:52 UTC
Created attachment 238071 [details] [review]
Patch including this new icon
Comment 4 Daniel Mustieles 2013-03-05 09:40:46 UTC
It's ok for me, but adding Matthias as CC since he could help us with this.

Many thanks for your quick response Javier! :)
Comment 5 Daniel Mustieles 2013-03-05 10:19:16 UTC
As I've read, it must be done with the script create-highcontrast, provided by gnome-themes-standard, but I don't know how it works.

I've created several highcontrast icons using /usr/share/icons as an argument for the script, but don't know how to specify acceciser icons :(

Matthias: can you help us with this?

Thanks!
Comment 6 Javier Hernández 2013-03-05 19:30:37 UTC
Hi!

I got some feedback from Bryen Yunashko (who uses HighContrast) and he told me that the icon is nicely visible to him.

AFAIK, this commit breaks the UI freeze, so I'll ask for this UI freeze break before pushing it to master.

Thank you Daniel!
Comment 7 Daniel Mustieles 2013-03-05 20:52:31 UTC
Many thanks to you for your quick response! :)
Comment 8 Daniel Mustieles 2013-03-07 15:46:47 UTC
Javier, could you please commit these changes to close this bug?

I'll update the wiki to set accerciser as done ;)

Thanks!
Comment 9 Javier Hernández 2013-03-07 18:01:03 UTC
Review of attachment 238071 [details] [review]:

commit: e2a093853ea6874e0ae7dabec5107e44e8ebd1fc

cheers!
Comment 10 Daniel Mustieles 2013-03-08 08:50:32 UTC
Wiki updated :)

Thanks!