GNOME Bugzilla – Bug 693322
Don't use deprecated GLib threading API
Last modified: 2013-02-11 12:04:16 UTC
several Mutex related fixes in GIT
Created attachment 235384 [details] [review] glib_compat_private: deprecated GStaticRecMutex
Created attachment 235385 [details] [review] gstrsvgoverlay: deprecated GStaticMutex -> GMutex
Created attachment 235386 [details] [review] gstchromahold: deprecated GStaticMutex -> GMutex
Created attachment 235387 [details] [review] mxfdemux: deprecated GStaticRWLock -> GRWLock
Created attachment 235388 [details] [review] fimc: deprecated pthread_mutex_t -> GMutex
Comment on attachment 235388 [details] [review] fimc: deprecated pthread_mutex_t -> GMutex This is not how it's supposed to be used now. It should be: static GMutex mutex; or GMutex mutex; in structs, and then g_mutex_{init,lock,unlock,clear}(&mutex);
Comment on attachment 235388 [details] [review] fimc: deprecated pthread_mutex_t -> GMutex Fixed differently: commit 8f93c2448edcfaf85aa0672c8d87655d9443d2ae Author: Tim-Philipp Müller <tim@centricular.net> Date: Sat Feb 9 18:46:48 2013 +0000 mfc: fix compilation with newer GLib versions that don't include pthread.h any more from public headers. We could just fix this by including pthread.h ourselves, but we may just as well use atomic ops for this and simplify the code a little. https://bugzilla.gnome.org/show_bug.cgi?id=693322
Comment on attachment 235384 [details] [review] glib_compat_private: deprecated GStaticRecMutex Not sure this makes sense? In any case, we can just remove it. It's only used in decklinksrc which hasn't been ported yet anyway (and swfdec which should be removed)
This is mostly fixed now, there are a few more related patches coming.