After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692786 - CAPS event is forwarded before STREAM_START in rtpptdemux element
CAPS event is forwarded before STREAM_START in rtpptdemux element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.5
Other Linux
: Normal normal
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-29 11:17 UTC by Paul HENRYS
Modified: 2013-02-07 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.28 KB, patch)
2013-01-29 11:17 UTC, Paul HENRYS
none Details | Review

Description Paul HENRYS 2013-01-29 11:17:17 UTC
Created attachment 234715 [details] [review]
Patch

In the chain function of the element, when a new PT is detected and a new src pad is created, first the CAPS event is pushed on the src pad and then the sticky_events using forward_sticky_events(). This leads to push CAPS event before STREAM_START event which should be sent before any other serialized event therefore CAPS event.
See the patch in attachment if it provided a correct solution.

Cheers,

Paul HENRYS
Comment 1 Wim Taymans 2013-02-07 13:41:15 UTC
commit 654c1974349298dada994a957260afad490945d4
Author: Paul HENRYS <visechelle@gmail.com>
Date:   Tue Jan 29 10:48:17 2013 +0100

    rtpptdemux: forward sticky events and then set caps
    
    When a new src pad is added, first forward the sticky events and then
    set the caps on the src pad
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=692786