After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692536 - Remove markup from translatable strings
Remove markup from translatable strings
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-25 15:00 UTC by B.Prathibha
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GNOME Goal: Remove markup in translatable strings (5.13 KB, patch)
2013-01-25 15:01 UTC, B.Prathibha 		needs-work Details | Review
Patch: Remove markup from translatable strings. (1.97 KB, patch)
2013-01-26 04:50 UTC, B.Prathibha 		committed Details | Review

Comment 1 B.Prathibha 2013-01-25 15:01:27 UTC 
Created attachment 234413 [details] [review]
GNOME Goal: Remove markup in translatable strings
Comment 2 Stef Walter 2013-01-25 18:14:27 UTC 
Review of attachment 234413 [details] [review]:

Thanks for the patch.

Could you remove all the various 'mode' changes from the patch? It seems to touch a lot of unrelated files.

::: ui/gcr-certificate-exporter.c
@@ +219,3 @@
 	os = g_file_create_finish (self->pv->output_file, res, &self->pv->error);
+	s = g_strdup_printf("<b>%s</b>",_("A file already exists with this name."));
+	msg = g_strdup_printf(_("%s\n\nDo you want to replace it with a new file?",s));

Although this removes markup, there is still formatting included in translated text. Could you do something like:

msg = g_strdup_printf ("<b>%s</b>\n\n%s",
                       _("heading"),
                       _("question"));

That also has the benefit of one less allocation.

As far as formatting, please note the space after the function names, and the way indentation is done with tabs up to the indentation level, and then spaces if something wraps to a specific column.

Thanks!
Comment 3 B.Prathibha 2013-01-26 04:50:31 UTC 
Created attachment 234457 [details] [review]
Patch: Remove markup from translatable strings.
Comment 4 Stef Walter 2013-02-12 05:56:42 UTC 
Attachment 234457 [details] pushed as 0708299 - Patch: Remove markup from translatable strings.

Fixed a memory leak, and indentation issues in the patch.