After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692209 - Update the icon names as per the guidelines from freedesktop.org
Update the icon names as per the guidelines from freedesktop.org
Status: RESOLVED OBSOLETE
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-21 16:34 UTC by B.Prathibha
Modified: 2020-11-23 21:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Icon Naming patch (14.10 KB, patch)
2013-01-21 16:35 UTC, B.Prathibha
rejected Details | Review

Description B.Prathibha 2013-01-21 16:34:40 UTC
For GNOME 3 all apps should conform to the Freedesktop.org icon-naming-spec.

See http://live.gnome.org/GnomeGoals/CorrectIconNames for background.
Comment 1 B.Prathibha 2013-01-21 16:35:30 UTC
Created attachment 234022 [details] [review]
Icon Naming patch

Updated the icon names using the standard names mentioned in the icon naming specs from freedesktop.org
Comment 2 Michael Catanzaro 2014-06-29 02:21:11 UTC
Review of attachment 234022 [details] [review]:

Sorry for the long delay

::: src/gpk-enum.c
@@ +77,3 @@
 	{PK_STATUS_ENUM_GENERATE_PACKAGE_LIST,	"pk-refresh-cache"}, /* TODO: need better icon */
 	{PK_STATUS_ENUM_WAITING_FOR_LOCK,	"pk-package-blocked"},
+	{PK_STATUS_ENUM_WAITING_FOR_AUTH,	"dialog-password"},

I looked through the whole patch, and this is honestly the only change that looks correct, since this is the only one that renames an icon.  For the rest it looks like you're accidentally renaming buttons that were better off with the original name, and even a few functions.

If you want to submit a new patch that only renames this icon, that'd be fine.
Comment 3 André Klapper 2020-11-23 21:21:16 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all older bug reports and feature requests in GNOME Bugzilla which have not seen updates for a while.

If you still use gnome-packagekit and if you still see this bug / want this feature in a recent and currently supported version, then please feel free to report it at
https://gitlab.gnome.org/GNOME/gnome-packagekit/-/issues/
by following the guidelines at
https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines

Thank you for creating this report and we are sorry it could not be implemented
so far (volunteer workforce and time is limited).