After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691985 - gst_pad_check_reconfigure: only remove flag if set.
gst_pad_check_reconfigure: only remove flag if set.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.x
Other Linux
: Normal trivial
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-18 00:58 UTC by Niv Sardi
Modified: 2013-01-27 21:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cosmetic fix (1.09 KB, patch)
2013-01-18 00:58 UTC, Niv Sardi 		committed Details | Review

Description Niv Sardi 2013-01-18 00:58:08 UTC 
Created attachment 233708 [details] [review]
cosmetic fix

the code ifed a debug statement, that can't be right. anyway, the way it is,
    we don't really need that branch, as we set the flag to unset only if set
    (and that can't fail) hence the end result is always to unset the flag.
    
    Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Comment 1 Wim Taymans 2013-01-24 14:42:08 UTC 
commit 4b3aee569840ed9ad2da936c951973f43b31bcd2
Author: Niv Sardi <xaiki@evilgiggle.com>
Date:   Thu Jan 17 21:35:48 2013 -0300

    gst_pad_check_reconfigure: only remove flag if set.
    
    the code ifed a debug statement, that can't be right. anyway, the way it is,
    we don't really need that branch, as we set the flag to unset only if set
    (and that can't fail) hence the end result is always to unset the flag.
    
    Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=691985