After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691174 - Add keywords to .desktop file
Add keywords to .desktop file
Status: RESOLVED FIXED
Product: ghex
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GHex maintainers
GHex maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-05 10:22 UTC by Daniel Mustieles
Modified: 2013-01-15 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add keywords to .desktop file (610 bytes, patch)
2013-01-05 10:22 UTC, Daniel Mustieles
needs-work Details | Review
Updated patch (680 bytes, patch)
2013-01-15 09:32 UTC, Daniel Mustieles
none Details | Review

Description Daniel Mustieles 2013-01-05 10:22:33 UTC
Created attachment 232813 [details] [review]
Add keywords to .desktop file

This makes GNOME Shell search more useful.

Take a look at: https://live.gnome.org/GnomeGoals/DesktopFileKeywords
Comment 1 Kalev Lember 2013-01-14 22:35:46 UTC
Review of attachment 232813 [details] [review]:

Hi Daniel

Thanks for the patch!

::: data/ghex.desktop.in
@@ +3,3 @@
 _GenericName=Hex Editor
 _Comment=Inspect and edit binary files
+_Keywords=hexadecimal;octal;debug;

Looking at the search behaviour of the current gnome-shell version in rawhide, it seems to match the words in Name and GenericName, but not those in Comment. So "Hex" and "Editor" already appear to be implicit keywords.

I'd rather not add "octal" as a keyword, it seems very unlikely that anyone would use that to search for GHex. Instead, a good keyword might be "binary", although that could be hard to translate -- in here it wouldn't mean the 2-base numeric system, but rather data that is not text. Compare "text editor" and "binary file editor". http://en.wikipedia.org/wiki/Binary_file

Is it possible to add translator comments in desktop files, to explain what "binary" means here?
Comment 2 Daniel Mustieles 2013-01-15 09:32:32 UTC
Created attachment 233508 [details] [review]
Updated patch

I agree with you about the "binary" keyword.

I've updated the patch and added a comment to the .desktop file (I've tested it and intltool recognises it properly, and comment appears in the PO file).

Thanks for your review :)
Comment 3 Kalev Lember 2013-01-15 17:10:22 UTC
Review of attachment 233508 [details] [review]:

::: data/ghex.desktop.in
@@ +3,3 @@
 _GenericName=Hex Editor
 _Comment=Inspect and edit binary files
+#TRANSLATORS: here, 'binary' means the 2-base numeric system

I was trying to say earlier that binary here would mean 'binary file' as opposed to 'text file', and NOT the 2-base numeric system.

http://en.wikipedia.org/wiki/Binary_file

Besides the comment I think it looks great, thanks!
Comment 4 Daniel Mustieles 2013-01-15 17:13:52 UTC
Oh, sorry, my mistake.

It's ok to commit changing the comment to this one: "here, 'binay' means a binary file (not the base-2 numeric system)"?
Comment 5 Kalev Lember 2013-01-15 17:27:11 UTC
Yes, perfect. Thanks!
Comment 6 Daniel Mustieles 2013-01-15 17:43:09 UTC
Done, thanks!