After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690963 - search-provider: implement support for the new DBus interface
search-provider: implement support for the new DBus interface
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-02 00:24 UTC by Giovanni Campagna
Modified: 2013-01-02 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-provider: implement support for the new DBus interface (30.43 KB, patch)
2013-01-02 00:24 UTC, Giovanni Campagna 		none Details | Review
search-provider: implement support for the new DBus interface (23.43 KB, patch)
2013-01-02 01:00 UTC, Giovanni Campagna 		none Details | Review
search-provider: implement support for the new DBus interface (23.41 KB, patch)
2013-01-02 21:52 UTC, Pierre-Yves Luyten 		none Details | Review

Description Giovanni Campagna 2013-01-02 00:24:35 UTC 
It gives us a timestamp in ActivateResult(), so startup notification
works without hacks.
At the same time, rework GApplication holding (we were calling release()
without ever calling hold()) and fix result activation (we were using
file:/// URIs for results, not note:///, so the results would be opened
in the browser)
Comment 1 Giovanni Campagna 2013-01-02 00:24:38 UTC 
Created attachment 232484 [details] [review]
search-provider: implement support for the new DBus interface
Comment 2 Giovanni Campagna 2013-01-02 01:00:09 UTC 
Created attachment 232490 [details] [review]
search-provider: implement support for the new DBus interface

It gives us a timestamp in ActivateResult(), so startup notification
works without hacks.
At the same time, rework GApplication holding (we were calling release()
without ever calling hold()) and fix result activation (we were using
file:/// URIs for results, not note:///, so the results would be opened
in the browser)

Now with less spurious hunks!
Comment 3 Pierre-Yves Luyten 2013-01-02 21:52:47 UTC 
Created attachment 232586 [details] [review]
search-provider: implement support for the new DBus interface

I just re-based the patch for convenience (because a recent commit already removed the warning)

Also sticked to gchar instead char, since the whole app use this.
Comment 4 Pierre-Yves Luyten 2013-01-02 21:58:31 UTC 
Oh i attached the patch instead updating git...done now 71fac7f34c5c122c04a8bc53a6068636608c7986