After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690946 - Add keywords to .desktop files
Add keywords to .desktop files
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-01 18:09 UTC by Daniel Mustieles
Modified: 2013-01-04 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add keywords to .desktop files (1.11 KB, patch)
2013-01-01 18:09 UTC, Daniel Mustieles 		needs-work Details | Review

Description Daniel Mustieles 2013-01-01 18:09:39 UTC 
Created attachment 232453 [details] [review]
Add keywords to .desktop files

This makes GNOME Shell search more useful.

Take a look at: https://live.gnome.org/GnomeGoals/DesktopFileKeywords
Comment 1 David Zeuthen (not reading bugmail) 2013-01-04 19:12:49 UTC 
Review of attachment 232453 [details] [review]:

I see that you pushed this patch (I assume, by accident) but since it's wrong, I've reverted it.

::: data/gnome-disk-image-mounter.desktop.in
@@ +3,3 @@
 _Name=Disk Image Mounter
 _Comment=Mount Disk Images
+_Keywords:ISO;

It's _Keywords=, not _Keywords:

::: data/gnome-disks.desktop.in
@@ +2,3 @@
 _Name=Disks
 _Comment=Manage Drives and Media
+_Keywords:device;volume;format;partition;resize;

Again, it's _Keywords=, not _Keywords:

I also think it's incorrect to use the keyword 'resize' since we actually don't support that operation yet.
Comment 2 David Zeuthen (not reading bugmail) 2013-01-04 19:20:55 UTC 
I've added these keywords instead

http://git.gnome.org/browse/gnome-disk-utility/commit/?id=333686ba569d567405d1a288eca9ba3980f48f47

but only to gnome-disks.desktop.in. I don't think it makes sense to add keywords to gnome-disk-image-mounter.desktop.in since it has NoDisplay=true, e.g. not displayed in the menus.
Comment 3 Daniel Mustieles 2013-01-04 19:27:09 UTC 
Ok, I agree with the change.

Thanks for your help and sorry for the noise.