GNOME Bugzilla – Bug 690255
Try to avoid small or low resolution thumbnails
Last modified: 2018-01-25 21:49:05 UTC
Created attachment 231620 [details] screenshot They look like they're upscaled from the small thumbnails in nautilus. They could really be regenerated.
This is related to bug 686895 I am beginning to wonder whether we should have gone for a separate attribute for forcing bigger thumbnails. I had a patch for that before I noticed that bug. Not sure. What do you think?
Bigger thumbnails would be a good start, otherwise, just generating your own wouldn't be so bad, as long as you do this carefully.
*** Bug 720610 has been marked as a duplicate of this bug. ***
These days (since bug 686851) nautilus creates larger thumbnails even if they are actually shown at a smaller size. So this is only an issue for users who have updated from older releases. I have proposed a patch in bug 686895 to let applications look specifically for large thumbnails instead of silently falling back to smaller sizes.
Created attachment 345741 [details] [review] Add an out-of-process custom thumbnailer
Created attachment 345742 [details] [review] Add PhotosThumbnailFactory
Created attachment 345745 [details] [review] Add an out-of-process custom thumbnailer
Created attachment 345746 [details] [review] Instantiate ThumbnailFactory right after MainWindow is created
Created attachment 345747 [details] [review] Switch to our own thumbnailing infrastructure
As mentioned in commit e62947cd9c7a and attachment 345745 [details] [review], there is a bug where some files, particularly JPEGs exported from Darktable, have strange diagonal distortions and are in monochrome. I can't see any obvious difference between our code and the desktop-wide GdkPixbuf thumbnailer. It will need further debugging, but since it's time for the 3.23.90 release and we have half a dozen thumbnailing related bugs open, I am going to close this. I'll repurpose some other bug for the follow-up fixes. Please re-open or leave a comment or file another bug if you spot further problems.
Created attachment 346371 [details] [review] thumbnailer: Use the correct typecast Found a typo.
Created attachment 346388 [details] [review] thumbnailer: Thumbnails should never be bigger than the source images
Created attachment 346536 [details] [review] thumbnail-factory: Remove redundant if branch
Created attachment 346537 [details] [review] pixbuf: Fix typo
(In reply to Debarshi Ray from comment #10) > As mentioned in commit e62947cd9c7a and attachment 345745 [details] [review] > [review], there is a bug where some files, particularly JPEGs exported from > Darktable, have strange diagonal distortions and are in monochrome. I can't > see any obvious difference between our code and the desktop-wide GdkPixbuf > thumbnailer. That's a bug in GEGL's GdkPixbuf source. See bug 779135. If we don't have a GEGL release with that fix in time for GNOME 3.24, we will carry our own GdkPixbuf source as a workaround.
*** Bug 777866 has been marked as a duplicate of this bug. ***
Created attachment 346871 [details] [review] build: Bump minimum GEGL version to 0.3.14
Created attachment 346874 [details] [review] Split the GEGL-related resources into a separate GResource
Created attachment 346875 [details] [review] thumbnailer: Register the GEGL-related resources
Created attachment 367442 [details] [review] thumbnail-factory: Remove still-born support for preview GIcons