After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689055 - Port contact map to geocode-glib 3.10
Port contact map to geocode-glib 3.10
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.8.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 686369 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-25 21:27 UTC by Bastien Nocera
Modified: 2013-11-18 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port contact map to geocode-glib >= 0.99.1 (4.24 KB, patch)
2012-11-25 21:27 UTC, Bastien Nocera 		none Details | Review
Port Evolution to geocode-glib-3.10 (4.35 KB, patch)
2013-10-27 20:28 UTC, Canek Peláez Valdés 		reviewed Details | Review

Description Bastien Nocera 2012-11-25 21:27:54 UTC 
.
Comment 1 Bastien Nocera 2012-11-25 21:27:56 UTC 
Created attachment 229860 [details] [review]
Port contact map to geocode-glib >= 0.99.1

Untested patch, but this should cover it.
Comment 2 Matthew Barnes 2012-11-28 01:13:17 UTC 
Thanks for the patch.  I'm going to hold off on committing this until after the next geocode-glib release.
Comment 3 Matthew Barnes 2012-12-12 14:29:02 UTC 
*** Bug 687323 has been marked as a duplicate of this bug. ***
Comment 4 Pacho Ramos 2013-08-02 05:55:46 UTC 
(In reply to comment #2)
> Thanks for the patch.  I'm going to hold off on committing this until after the
> next geocode-glib release.

It was released some days ago :)
Comment 5 Canek Peláez Valdés 2013-10-27 20:28:10 UTC 
Created attachment 258245 [details] [review]
Port Evolution to geocode-glib-3.10

I updated the patch so it works with geocode-glib-3.10. Evolution compiles with it and it kinda works, but more testing is required.
Comment 6 Matthew Barnes 2013-10-27 21:12:52 UTC 
Thanks for this!  It's been on my To-Do list for awhile now.

I'll review the patch in more detail tomorrow.
Comment 7 Matthew Barnes 2013-10-31 20:31:07 UTC 
After cleaning up the compiler warnings and fixing a couple bugs the patch seems to work.  Bumping our requirement to geocode-glib 3.10 instead of 0.99.1.

Fixed for Evolution 3.11.2:

https://git.gnome.org/browse/evolution/commit/?id=8eb21abc046be972a82afedb3a0ab844b00ec7e3

The actual map UI needed further work, which I pushed in subsequent commits.
The Address Book Map feature should be back on its feet now.
Comment 8 Matthew Barnes 2013-11-18 16:30:30 UTC 
*** Bug 686369 has been marked as a duplicate of this bug. ***