After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688644 - Update gst-libav to libav 9 API
Update gst-libav to libav 9 API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
unspecified
Other All
: Normal blocker
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 688097 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-19 14:32 UTC by Luca Barbato
Modified: 2012-12-12 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update to use AVOptions variants. (5.38 KB, patch)
2012-11-19 14:32 UTC, Luca Barbato
committed Details | Review
example patch showing how the public avio interface can be used to connect muxers and demuxers (16.36 KB, patch)
2012-12-10 23:36 UTC, Christiaan Welvaart
committed Details | Review

Description Luca Barbato 2012-11-19 14:32:33 UTC
Created attachment 229370 [details] [review]
Update to use AVOptions variants.

Most of the changes are easy (AV_ namespace on many macro definitions), some are immediate (switch to the alloc/open functions using AVOptions), some are more complex (move from URLProtocol to AVIO and use the encoding functions using AVFrames instead of buffer).

All in all it should reduce the number of lines of code and simplify a lot.
Comment 1 Tim-Philipp Müller 2012-11-19 14:51:47 UTC
*** Bug 688097 has been marked as a duplicate of this bug. ***
Comment 2 Sebastian Dröge (slomo) 2012-12-04 21:14:58 UTC
commit aa4a2385064dabec05d68b59660e947e50115452
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 22:09:05 2012 +0100

    avauddec: release_buffer is not supposed to be used for audio
    
    And calling it causes crashes in some situations.

commit e092f3d41183e9e901c0f86961124d237a82895e
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 20:45:28 2012 +0100

    avauddec: Add support for planar audio formats

commit 47647e1caca117ff8a62caf8bf0b6c94eb6dd025
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 20:44:58 2012 +0100

    avviddec: Fix memory leaks and assertions in error cases if we can't allocate a frame

commit f5c112990f397f8b160966cdb6fb7420c45246d5
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 18:28:11 2012 +0100

    av: Port remaining simple bits

commit 0f206124b682790a3f96a3bee110f9c2350f3348
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 18:02:56 2012 +0100

    av: Remove palette support for now
    
    It was never ported to the way how paletted color formats work
    in 1.0 anyway and the API changed in libav upstream.

commit 169825a28e750e8fa433d3bc997d4e186c99b3eb
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 17:56:40 2012 +0100

    av: Update for some constant changes

commit 06ed3e40604b2a4683b0edfaae1f3ae6ccee0e57
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 17:47:20 2012 +0100

    av: Port to new avio protocol handler

commit 5f03a7d8690578f9754ec33a9c418109d7327dc3
Author: Luca Barbato <lu_zero@gentoo.org>
Date:   Mon Nov 19 15:25:42 2012 +0100

    av: update to use AVOption variants.

commit 41e117562c5e6d7afa7b12977e3442550213b694
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Dec 4 17:19:11 2012 +0100

    libav: Switch to master (9)
Comment 3 Christiaan Welvaart 2012-12-10 23:36:39 UTC
Created attachment 231224 [details] [review]
example patch showing how the public avio interface can be used to connect muxers and demuxers
Comment 4 Sebastian Dröge (slomo) 2012-12-11 11:05:37 UTC
Hi Christiaan, could you update that patch to latest GIT master? Some of these things are already done but I wasn't aware of the fact that the API I switched to was not public API.
Comment 5 Sebastian Dröge (slomo) 2012-12-12 11:26:19 UTC
Looking at that myself now :)
Comment 6 Sebastian Dröge (slomo) 2012-12-12 12:11:06 UTC
commit 338b147374f4e4557b532c89b9eb6b6b907fa955
Author: Christiaan Welvaart <cjw@daneel.dyndns.org>
Date:   Wed Dec 12 12:09:32 2012 +0000

    avprotocol: Port from the URL protocol handler to saner public API