After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687885 - add keywords to the desktop file
add keywords to the desktop file
Status: RESOLVED FIXED
Product: accerciser
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Accerciser Developers
Accerciser Developers
Depends on:
Blocks:
 
 
Reported: 2012-11-07 21:23 UTC by Oliver Propst
Modified: 2013-01-15 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (714 bytes, patch)
2012-11-07 21:23 UTC, Oliver Propst
needs-work Details | Review
Patch updated (709 bytes, patch)
2013-01-15 09:39 UTC, Daniel Mustieles
reviewed Details | Review

Description Oliver Propst 2012-11-07 21:23:49 UTC
Created attachment 228422 [details] [review]
patch

this makes gnome-shell search more useful.

see https://live.gnome.org/GnomeGoals/DesktopFileKeywords
Comment 1 Daniel Mustieles 2013-01-01 18:21:17 UTC
Can this patch be commited into git?

Thanks!
Comment 2 Javier Hernández 2013-01-14 23:45:03 UTC
Review of attachment 228422 [details] [review]:

Thanks for the patch!

Althought the changes are trivial, I think that this patch could be better than currently is.

_Keywords=accessibility;developer;test;

I've been reviewing the GNOME Goal and I've been looking for some examples and I prefer to use "development" rather than "developer" as a keyword (like anjuta's desktop file).
If you're agree with it, please apply that slightly change and update the patch on the report.

Thanks again for your help.
Best regards,
Javi
Comment 3 Daniel Mustieles 2013-01-15 09:39:05 UTC
Created attachment 233509 [details] [review]
Patch updated

You are alive!! ;-)

Agree with you. Here is the patch updated so, if it's ok, let me know to push it and update the wiki page.

Many thanks for your review.

P.S. Did you recieve my mail about the remove-markup goal?
Comment 4 Javier Hernández 2013-01-15 11:56:14 UTC
Review of attachment 233509 [details] [review]:

Hi Daniel!

Thank you for your quick movement! ;) (and yes, I'm alive!) :P

Since Oliver was the one who reported and provided the inital patch, I'd like to respect his initial authorship.
I hope you understand it. 

Anyway, thanks again for your (always very good and full of quality) contributions, you rock!

Cheers!

PS: Yes, I saw the mail and is still pending to be answered, so stay tuned! ;)
Comment 5 Daniel Mustieles 2013-01-15 12:00:04 UTC
(In reply to comment #4)
> Review of attachment 233509 [details] [review]:
> 
> Hi Daniel!
> 
> Thank you for your quick movement! ;) (and yes, I'm alive!) :P
> 
> Since Oliver was the one who reported and provided the inital patch, I'd like
> to respect his initial authorship.
> I hope you understand it.

Sure, don't worry about that. If you agree with the keywords proposed in the last patch, please push it so we can clos this bug and update the wiki page.

Many thanks to you!
Comment 6 Javier Hernández 2013-01-15 13:09:03 UTC
pushed to master, see commit: 08b4d7ba76f19430f9e39a3a6f83ba49351d2e6d

Thank you Daniel!

Cheers,
Javi
Comment 7 Javier Hernández 2013-01-15 13:10:14 UTC
Review of attachment 233509 [details] [review]:

setting status to reviewed
Comment 8 Daniel Mustieles 2013-01-15 13:11:56 UTC
(In reply to comment #6)
> pushed to master, see commit: 08b4d7ba76f19430f9e39a3a6f83ba49351d2e6d
> 
> Thank you Daniel!
> 
> Cheers,
> Javi

And wiki updated

Thanks!