After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687380 - videomixer: Y offset should be compared to height, not width
videomixer: Y offset should be compared to height, not width
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-01 22:14 UTC by Douglas Bagnall
Modified: 2012-11-02 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch (1.37 KB, patch)
2012-11-01 22:14 UTC, Douglas Bagnall 		committed Details | Review

Description Douglas Bagnall 2012-11-01 22:14:15 UTC 
Created attachment 227844 [details] [review]
A patch

As with bug 687330, videomixer mixes up its axes. From the patch:

    /* If x or y offset are larger then the source it's outside of the picture */ \
-  if (xoffset > src_width || yoffset > src_width) { \
+  if (xoffset > src_width || yoffset > src_height) { \
     return; \

And quoting the commit message:

This could have prevented images showing that should have when the
source height is greater than its width.

When width exceeds height, as is common, it probably only caused a
miniscule amount of unnecessary work.  I haven't tested.
Comment 1 Sebastian Dröge (slomo) 2012-11-02 08:29:58 UTC 
commit 0b898ab91109e5a3197ac4b27178c1e040415303
Author: Douglas Bagnall <douglas@paradise.net.nz>
Date:   Fri Nov 2 10:53:57 2012 +1300

    videoconvert: Compare y offset with height, not width, when testing for overlap
    
    This could have prevented images showing that should have when the
    source height is greater than its width.
    
    When width exceeds height, as is common, it probably only caused a
    miniscule amount of unnecessary work.  I haven't tested.