After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686294 - tsdemux: Fix checking P-STD_buffer marker in PES header
tsdemux: Fix checking P-STD_buffer marker in PES header
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other All
: Normal normal
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-17 12:53 UTC by Raimo Järvi
Modified: 2012-10-19 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tsdemux: Fix parsing P-STD_buffer in PES header (956 bytes, patch)
2012-10-17 12:55 UTC, Raimo Järvi 		committed Details | Review

Description Raimo Järvi 2012-10-17 12:53:48 UTC 
Check for P-STD_buffer marker is incorrect, which will cause all PES packets with P-STD_buffer_flag == 1 to be discarded.
Comment 1 Raimo Järvi 2012-10-17 12:55:39 UTC 
Created attachment 226639 [details] [review]
tsdemux: Fix parsing P-STD_buffer in PES header
Comment 2 Tim-Philipp Müller 2012-10-19 00:07:43 UTC 
Thanks, pushed! Plus a few others, which also looked wrong.


commit 465374f3c8fd1dc2db3c79fe4de34636faedb18a
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Fri Oct 19 01:03:51 2012 +0100

    tsdemux: fix program packet sequence counter parsing in PES header

commit 10c881b107f0541d40aae1a8bf203144bfb93bb9
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Fri Oct 19 00:47:45 2012 +0100

    tsdemux: fix some inconsequential PES header parsing issues
    
    additional_copy_info: need to get rid of the highest
    bit, not the lowest one
    
    program_packet_sequence_counter: also need to get rid
    of the highest bit instead of multiplying with a random
    value
    
    original_stuff_length: want to AND 0x3f to extract the
    lowest 6 bits, not multiply by it.
    
    None of these fields are actually used though, so these
    should not have caused any issues.

commit 96406696898665db36d0a4665a4629c89f45b54e
Author: Raimo Järvi <raimo.jarvi@gmail.com>
Date:   Wed Oct 17 15:54:32 2012 +0300

    tsdemux: Fix parsing P-STD_buffer in PES header
    
    https://bugzilla.gnome.org/show_bug.cgi?id=686294