GNOME Bugzilla – Bug 685263
Enabling interrupt in speechdispatcher factory cuts off things it should not
Last modified: 2018-02-08 13:04:55 UTC
Created attachment 225551 [details] Debug file with show possible why happening this issue Dear Joanie, I experienced very slow speech output refresh if I using GNOME 3.6 awailable System Settings preference tool (gnome-control-center application). I tested this issue under Ubuntu 12.10 daily live cd (this distro awailable Orca 3.7.90 version I think), and Fedora 18 latest awailable live CD (this distro awailable with Orca 3.5.4 version). In Orca preferences dialog the speech page I checked speak mnemonics, speak tutorial messages and speak child position check boxes, checked braille page the enable braille support check bock, and key echo page I uncheck all check boxes except alpha numeric echo related check box. In Ubuntu 12.10 I used Unity 3D environment, in Fedora 18 I used default GNOME Shell environment. Reproducation steps if you would like testing this issue under Fedora: 1. Launch Orca, and check I wrote check boxes in Orca preferences dialog. 2. Click System Settings possibility. 3. Select a category, and move between category items with arrow keys fast. This situation when I fast move between items with arrow keys, Orca producing a delay until not spokening the prewious selected item. I attaching the created debug.out file. Attila
The problem is that we normally interrupt speech with keypresses. If gnome-control-center doesn't tell us about keypresses we don't know about them. That, plus the fact that Will had years ago commented out the interrupt speech functionality in Orca's code for speech-dispatcher means that we were never shutting up. I re-enabled the code Will had commented out and things are working as expected. http://git.gnome.org/browse/orca/commit/?id=7c7f386050abc40ee1234b240bafcf12615a38f6
Test experiences in Ubuntu 13.04 development release with latest Orca master version: When I goto my home folder and browsing folders and files with arrow keys, I not hear any file names and folder names. Orca want spokening all informations but I hear real only the position index value information. Another dialog with I experienced this issue with Orca preferences dialog. I try reverting the committed fix my local system and will be write short time later this is resolve the experienced issues or not my system.
Created attachment 233137 [details] [review] Revert the prewious committed fix Joanie, if not have other solution, please commit this patch. This patch revert the prewious commit this bug related. All I wrote unwanted issues are resolved if I using this patch. With speech support Orca preferences dialog works good again, and in Nautilus I hear again all wanted files and folders related informations. Attila
José confirmed my experienced negative issues unfortunately, but different simptomns. He wrote following experiences with this bug related commit: "1. If the option 'speak child position' is on, orca doesn't announce corectly the menus, radio buttons, combo boxes and etc. Instead of announce for exemple new, 1 of 5, orca only reads: 1 of 5. 2. The links in firefox are not announced, only the word link is read." Why interrupt Orca too short time the speech if the wrote commit is not reverted? What situations returning the interrupt variable with true value? General the speak and speakUtterances functions the interrupt parameter value is true. So, if reverting this fix not good way, need examining the application is tells keypresses or not. If keypress happening and application is tells this information, absolute sure need interrupting the speech before next highlighted informations is need spokening. If an application not telling happened a keypress or not (if I understanding right GNOME Control Center doing this), absolute sure need interrupting the speech before next information spokening is happening. But need prewenting any way speech users not lost any important informations. Attila
The problems with links in FF happens only when I press the tab key. When I press the tab key and a link is reached, orca reads only link. If I use arrows to navigate in the document, the links are read correctly.
Hy José, With menues related you experienced arrow keys related this problem? For example if I opening my home folder with Nautilus and this commit are not reverted, I hear only position index values with files and folders. If I goto the desktop, I hear only the tutorial message. Hopefuly I remember right, but in Orca preferences dialogue when I use TAB or SHIFT+TAB keys I hear checkboxes related the state (checked or unchecked) when this commit is not reverted. Attila
I reverted the fix. Based on these findings, and given that the underlying problem is in the control center, I'm going to make this bug a dup of the real bug. Once I find it (because I swear I already filed it) or failing that, file it. BTW Attila, git has a revert command so no need for patches.
I filed bug 691468 against gnome-control-center. Rather than closing this bug out, I'm going to repurpose it. Because having thought about it some more, even though the now-reversed fix hacks around the problem, it should theoretically work. The side effects described here suggest that we are speaking things all over the place using interrupt set to True when clearly it should be set to False. Given the "all over the place" issue, I'm going to need to take some time to really sort out all the speech stuff. Thanks for the quick testing, btw.
(In reply to comment #6) > Hy José, > > With menues related you experienced arrow keys related this problem? For > example if I opening my home folder with Nautilus and this commit are not > reverted, I hear only position index values with files and folders. > If I goto the desktop, I hear only the tutorial message. > Hopefuly I remember right, but in Orca preferences dialogue when I use TAB or > SHIFT+TAB keys I hear checkboxes related the state (checked or unchecked) when > this commit is not reverted. The behavior described in my previous message is present in gedit, eclipse, gnome-terminal, thunderbird and etc.. All applications that has a menubar. > > Attila
Since bug #691468 seems to be fixed, this one can be closed?
No, for the reasons I give in comment #8.