GNOME Bugzilla – Bug 685107
Unexpected error return from mpeg2dec
Last modified: 2012-10-01 00:44:15 UTC
Created attachment 225394 [details] Log of mpeg2dec failure This is a problem I'm having with mpeg2dec, but I think it may be a base video decoder bug, so filing there. The problem is a spontaneous error returned from the chain function with a DVD that works fine in the last 0.10 releases.
Created attachment 225426 [details] [review] mpeg2dec: Don't error out when there is no associated buffer In 0.10, having mpeg2dec occasionally tell us to output a frame that was never decoded was just ignored, so do the same in 1.0 Fixes: #685107
Any reason you didn't just push that? Seems better than erroring out. Do we need to move time along or something if this happens? (What happens when e.g. garbage can't be decoded, for example? Is that the same code path then?) Do you still think there is something left to do in videodecoder to handle this better?
No real reason, although I'm not completely sure of the fix.