After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685107 - Unexpected error return from mpeg2dec
Unexpected error return from mpeg2dec
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 1.0.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-29 19:01 UTC by Jan Schmidt
Modified: 2012-10-01 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Log of mpeg2dec failure (253.95 KB, application/x-bzip)
2012-09-29 19:01 UTC, Jan Schmidt
  Details
mpeg2dec: Don't error out when there is no associated buffer (904 bytes, patch)
2012-09-30 14:03 UTC, Jan Schmidt
none Details | Review

Description Jan Schmidt 2012-09-29 19:01:17 UTC
Created attachment 225394 [details]
Log of mpeg2dec failure

This is a problem I'm having with mpeg2dec, but I think it may be a base video decoder bug, so filing there.

The problem is a spontaneous error returned from the chain function with a DVD that works fine in the last 0.10 releases.
Comment 1 Jan Schmidt 2012-09-30 14:03:53 UTC
Created attachment 225426 [details] [review]
mpeg2dec: Don't error out when there is no associated buffer

In 0.10, having mpeg2dec occasionally tell us to output a frame that
was never decoded was just ignored, so do the same in 1.0

Fixes: #685107
Comment 2 Tim-Philipp Müller 2012-09-30 15:11:50 UTC
Any reason you didn't just push that? Seems better than erroring out. Do we need to move time along or something if this happens? (What happens when e.g. garbage can't be decoded, for example? Is that the same code path then?)

Do you still think there is something left to do in videodecoder to handle this better?
Comment 3 Jan Schmidt 2012-09-30 23:15:39 UTC
No real reason, although I'm not completely sure of the fix.