After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684055 - widget: set toplevel-relative position style classes on widgets
widget: set toplevel-relative position style classes on widgets
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
: 688201 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-15 00:13 UTC by Cosimo Cecchi
Modified: 2018-05-02 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
widget: set toplevel-relative position style classes on widgets (5.20 KB, patch)
2012-09-15 00:13 UTC, Cosimo Cecchi 		reviewed Details | Review

Description Cosimo Cecchi 2012-09-15 00:13:36 UTC 
In Adwaita, we currently special case many applications to remove the border from an edge touching the toplevel; it would be nice if GTK added a style class with such a hint automatically.
Comment 1 Cosimo Cecchi 2012-09-15 00:13:38 UTC 
Created attachment 224373 [details] [review]
widget: set toplevel-relative position style classes on widgets

During the size allocation cycle, check if the allocated position
touches the toplevel edges, and set a style class saying so on the
widget.
This is very useful for themes that want to hide the edges for e.g.
expanded scrolled views to increase the Fitts-ness of the scrollbars.
Comment 2 Lapo Calamandrei 2012-09-15 12:30:13 UTC 
Niiiiiiiiiiiiiiiiiiice
Comment 3 Matthias Clasen 2012-09-15 19:18:01 UTC 
Review of attachment 224373 [details] [review]:

Looks like a potentially expensive hack to me. Also, changing style classes can change size allocation again - live-lock danger. What if a parent adds padding between the widget and the edge - no longer touching ?
Comment 4 Lapo Calamandrei 2012-09-18 11:55:18 UTC 
The class should just go away. This is a really needed feature to have apps to look nice by default (well at least is a start) w/o custom css.
Comment 5 Cosimo Cecchi 2012-11-12 19:24:59 UTC 
*** Bug 688201 has been marked as a duplicate of this bug. ***
Comment 6 Matthias Clasen 2018-02-10 05:05:27 UTC 
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 7 Lapo Calamandrei 2018-02-12 11:56:26 UTC 
Something addressing the double border issue would still be very nice to have, reopening.
Comment 8 GNOME Infrastructure Team 2018-05-02 15:29:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/405.