After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683759 - Incorrect use of AppMenu
Incorrect use of AppMenu
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
: 684602 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-11 01:36 UTC by Jean-François Fortin Tam
Modified: 2012-09-22 06:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (30.75 KB, image/png)
2012-09-11 01:36 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2012-09-11 01:36:06 UTC
Created attachment 223967 [details]
screenshot

Hi ! As the attached screenshot indicates (with two menubars), you might be incorrectly using the appmenu functionality of gtkapplication. Normally I see such apps having only one menu bar...

Also, if you'd like a usability review on the prospect of killing the menubar entirely/redesigning your UI, let me know and I'd be happy to help.
Comment 1 Christian Persch 2012-09-11 11:04:44 UTC
It's not using it 'incorrectly'; it simply isn't using GMenu for the main menubar, so GtkApplicationWindow can't combine the two menubars.

A quick way to fix this would be to do what I do e.g. in evince, gnome-terminal, gucharmap, that is to only install the app menu if there's gnome-shell actually running to show it. Just putting this at the top of initialize_app_menu() in main.c would do it:

  gboolean show_app_menu;
  g_object_get (gtk_settings_get_default (),
                "gtk-shell-shows-app-menu", &show_app_menu,
                NULL);
  if (!show_app_menu)
    return;
Comment 2 Paolo Bacchilega 2012-09-11 15:58:40 UTC
fixed now, thanks for the hint.
Comment 3 Paolo Bacchilega 2012-09-11 16:38:53 UTC
(In reply to comment #0)

> 
> Also, if you'd like a usability review on the prospect of killing the menubar
> entirely/redesigning your UI, let me know and I'd be happy to help.

I'd like to see such a review, thanks for your interest.
Comment 4 Paolo Bacchilega 2012-09-22 06:57:07 UTC
*** Bug 684602 has been marked as a duplicate of this bug. ***