After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682615 - Matroska: expand tag mapping
Matroska: expand tag mapping
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-24 14:49 UTC by LRN
Modified: 2012-10-28 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Expand tag mapping (18.20 KB, patch)
2012-08-24 14:50 UTC, LRN
none Details | Review
Expand tag mapping V2 (18.50 KB, patch)
2012-10-25 16:32 UTC, LRN
committed Details | Review

Description LRN 2012-08-24 14:49:44 UTC
Make Matroska reader map more Matroska tags to GStreamer tags.
Comment 1 LRN 2012-08-24 14:50:42 UTC
Created attachment 222342 [details] [review]
Expand tag mapping

* Also expose unknown tags as key=value pairs.
* Arrange tag map in the same order tags are listed in Matroska spec, leaving
unmapped tags as comments.
* More specific TODOs.
* Remove duplicate DATE define.

Depends on #682448, #682524
Comment 2 LRN 2012-08-24 15:01:12 UTC
To developers: What do you think about expanding official GStreamer tag list with new GST_TAG_* definitions?

There aren't that many tag systems in the world (id3*, Matroska, Ogg Comments, APE, MOV/MP4 - that's about all, i think?). Creating GStreamer counterparts for each tag in these systems (that isn't already defined) would increase the number of tags significantly (possibly up to 100-200), but it's still a finite number.

Some tags might be viewed as being too elaborately detailed, and can be replaced with generic versions (say, "SCRIPT_BY", "DIRECTOR", "EDITED_BY" and other Matroska tags can be replaced with a single generic "CONTRIBUTOR" tag that will hold multiple values). If that is done, the number of new tags will drop dramatically.
Comment 3 LRN 2012-08-29 23:53:09 UTC
If file has both LICENSE and TERMS_OF_USE tags, only one will be read.

This is true for all tags that have merge_func set to NULL (which means lots of tags), even if GST_TAG_MERGE_APPEND is used.

From looking at the code it seems that GST_TAG_MERGE_PREPEND will work, however.
Comment 4 LRN 2012-10-25 16:32:29 UTC
Created attachment 227285 [details] [review]
Expand tag mapping V2
Comment 5 Sebastian Dröge (slomo) 2012-10-26 08:13:40 UTC
commit cd719bb80858575270a84e746a8c893803b90235
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Fri Aug 24 13:55:41 2012 +0400

    matroskademux: Expand the tag mapping.
    
    * Also expose unknown tags as key=value pairs.
    * Arrange tag map in the same order tags are listed in Matroska spec, leaving
    unmapped tags as comments.
    * More specific TODOs.
    * Remove duplicate DATE define.
    
    Fixes #682615
    Depends on #682524
Comment 6 Sebastian Dröge (slomo) 2012-10-26 08:14:19 UTC
(In reply to comment #2)
> To developers: What do you think about expanding official GStreamer tag list
> with new GST_TAG_* definitions?
> 
> There aren't that many tag systems in the world (id3*, Matroska, Ogg Comments,
> APE, MOV/MP4 - that's about all, i think?). Creating GStreamer counterparts for
> each tag in these systems (that isn't already defined) would increase the
> number of tags significantly (possibly up to 100-200), but it's still a finite
> number.
> 
> Some tags might be viewed as being too elaborately detailed, and can be
> replaced with generic versions (say, "SCRIPT_BY", "DIRECTOR", "EDITED_BY" and
> other Matroska tags can be replaced with a single generic "CONTRIBUTOR" tag
> that will hold multiple values). If that is done, the number of new tags will
> drop dramatically.

Sounds like a good idea but should be done in a different bug