After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682456 - Don't show nm-connection-editor launcher in GNOME
Don't show nm-connection-editor launcher in GNOME
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
git master
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
NetworkManager maintainer(s)
: 684902 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-22 12:21 UTC by Elad Alfassa
Modified: 2014-08-21 18:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] connection-editor: Don't show launcher in GNOME (903 bytes, patch)
2012-08-22 12:21 UTC, Elad Alfassa
accepted-commit_now Details | Review

Description Elad Alfassa 2012-08-22 12:21:41 UTC
Created attachment 222135 [details] [review]
[PATCH] connection-editor: Don't show launcher in GNOME

As discussed with aday, control-center will spawn nm-connection-editor when needed, and therefor we really don't need the launcher shown, it clutters the Application list.
Comment 1 Allan Day 2012-08-22 18:08:36 UTC
Thanks for filing this, Elad.

It would be great not to require nm-connection-editor to be installed by default. For most people System Settings should cover all their networking needs. The presence of the nm-c-e launcher is potentially confusing ("Which network thingy do I use?"), it's also one more thing that people need to navigate when launching applications.

However, if we do hide the nm-c-e launcher, we need to be sure that System Settings can provide all the functionality it provides. I'm not entirely sure that that's the case.

Reconstructing the discussion from IRC today:

[can system settings do everything that nm-c-e can?]

<danw> ... nm-connection-editor now has support for infiniband, wimax, and bonds, and will have support for vlans and maybe bridges soon. So, people with those types of connections will still need it
<mclasen> danw: do these connection types show up in the network panel at all ?
<mclasen> it would be good if we could make all these show up just as 'wired' or somesuch
<mclasen> and then jump to nm-c-e from there
<danw> no, they don't currently show up at all
<danw> hm.... actually, I have to "(null)" entries in my control panel network list, and if I click on them, it crashes...
<danw> s/to/two/
<mclasen> danw: would be good to have that in bugzilla, and blocking bug 677152

Based on this, it looks like bug 677152 needs to be fixed before we can hide the desktop file in GNOME.

Another possible approach would be to suggest that distributions package the nm-c-e desktop file separately, so that System Settings can still launch the dialogs it needs, but the tool is still available if needed. (Don't know how stupid that idea is.)
Comment 2 William Jon McCann 2012-09-26 18:34:11 UTC
This logic is really strange. We don't support enterprise networking features. We show nothing about them in the "Network Settings". We even have a tracking bug about it. So, to *support* those scenarios we include a separate launcher in the application list for them. In the process confusing the heck out of all the rest of our users. This makes no sense.

If we can't get to a place where we support these enterprise use cases fully then at minimum we can add a way to launch this connection editor from the place where everyone would go looking for it - the Network Settings. And stop pretending it is an application launcher.
Comment 3 William Jon McCann 2012-09-26 18:34:32 UTC
*** Bug 684902 has been marked as a duplicate of this bug. ***
Comment 4 Arnaud B. 2014-02-04 08:19:41 UTC
Important related bug: nm-connection-editor is shown in Software, and is removable; it removes in this case Control Center (silently), and that’s really bad.
Comment 5 Michael Catanzaro 2014-02-08 20:39:54 UTC
(In reply to comment #4)
> Important related bug: nm-connection-editor is shown in Software, and is
> removable; it removes in this case Control Center (silently), and that’s really
> bad.

I filed Bug #723922
Comment 6 Andrei Amuraritei 2014-05-13 00:14:56 UTC
If you hide this from apps list, then how can I for example, activate a simple 
internet connection sharing profile, seeing as that functionality is missing from nm-applet ?

Or maybe a new bug is needed to add the Shared to other computers method for connection IPv4 from Network settings in System Settings.
Comment 7 Elad Alfassa 2014-08-17 20:42:06 UTC
(In reply to comment #6)
> If you hide this from apps list, then how can I for example, activate a simple 
> internet connection sharing profile, seeing as that functionality is missing
> from nm-applet ?
> 
> Or maybe a new bug is needed to add the Shared to other computers method for
> connection IPv4 from Network settings in System Settings.

This is tracked in bug #696793

I still think this launcher should not be shown in GNOME by default.
Comment 8 Michael Catanzaro 2014-08-17 21:05:00 UTC
Time to do this, please? The bugs mentioned in comment #1 are resolved.

(In reply to comment #6)
> If you hide this from apps list, then how can I for example, activate a simple 
> internet connection sharing profile, seeing as that functionality is missing
> from nm-applet ?
>
> Or maybe a new bug is needed to add the Shared to other computers method for
> connection IPv4 from Network settings in System Settings.

Yup.

Unfortunately gnome-control-center still launches nm-connection-editor in net-device-wifi.c and net-device.c; if not for that, we could just not install it by default and would not need NoDisplay=True; or NoShowIn=GNOME;
Comment 9 Dan Winship 2014-08-21 18:21:19 UTC
Comment on attachment 222135 [details] [review]
[PATCH] connection-editor: Don't show launcher in GNOME

Sure